-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hideIfPermissionsNotMet flag is always false and hidden channels are visible #14608
Comments
required for status-im/status-mobile#19885 |
We confirmed that the Status Community still works correctly on RC6 (the channel that should be hidden are indeed hidden). Can you post screenshots of the settings and permissions and the resulting visible channel. It would be good to see if everything is setup correctly. |
Thank you @jrainville for looking into this and your quick response. Here is the video with the steps. output-2024-05-06_20.31.59.mp4 |
Thanks for the video. It does seem like there is an issue. We can see in the Owner screen that the channel's status does update correctly. The member list gets updated so that only the Owner is present in the list, filtering out the other members that do not have ETH. However, on the member account, you can still see the channel. The member list is empty, so I wonder it's related to this issue: #14442 If you restart the app, does the channel finally get removed? And does the channel list stay empty? In theory, that's normal, because the member list is encrypted. So either on first receiving the channel, the app doesn't compute the hideIfPermissionsNotMet property or there it's something completely broken. But then how does it work in the Status community 🤔 |
hi @jrainville, Even in mobile these community channels have
Don't know, maybe status community are channels created before this bug. |
No
Yes channel member list stays empty |
Ah! I made a discovery! It seems like the issue only happens when the "Hide permission" check box is selected. "Hie Permission" ON -> Channel appears |
@jrainville Thank you very for fixing the issue. I am currently using a build (#11) from #14537, as this also includes your fix, but I am not able to add permission output-2024-05-12_18.00.07.mp4 |
@Parveshdhull , that seems like a UI bug. It would be very kind of you to open it in an other issue. If you want to create a permission in the meantime, I recommend using the Admin panels. Click on the community name at the top -> Permisisons -> Add |
Bug Report
Description
While creating a channel I have selected
Hide channel from members who don't have permission to view the channel
.But hideIfPermissionsNotMet is always false. I created this channel in 2.28.1-rc.6 and checked these channels in mobile client and desktop.
Also checked in 2.28.0
Steps to reproduce
Step 1: Create a channel with
hideIfPermissionsNotMet
true and add permission tokenStep 2: Open member account who have access/joined the same community but don't have required token for the channel view access
Step 3: Channel is still visible
Expected behavior
Channel should not be visible
Actual behavior
Channel is visible
Additional Information
The text was updated successfully, but these errors were encountered: