Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Wallet Connect SDK from disk in storybook and from binary (QRC) in the app #14696

Open
stefandunca opened this issue May 10, 2024 · 0 comments

Comments

@stefandunca
Copy link
Contributor

stefandunca commented May 10, 2024

Following on the discussion here #14590 use the QT's flexible mechanism to alternatively load the SDK from disk as proposed by @micieslak.

From the Qt documentation: https://doc.qt.io/qt-5/qml-url.html

The url type refers to a resource locator (like a file name, for example). It can be either absolute, e.g. "http://qt-project.org", or relative, e.g. "pics/logo.png". A relative URL is resolved relative to the URL of the containing component.
Note: When referring to files stored with the [Qt Resource System](https://doc.qt.io/qt-5/resources.html) from within QML, you should use "qrc:///" instead of ":/" as QML requires URL paths. Relative URLs resolved from within that file will use the same protocol.

Based on the QT specifications and given the fact that WalletConnectSDK is loaded from resources in the app we can ensure the SDK is also loaded from resources.

stefandunca added a commit that referenced this issue May 10, 2024
@noeliaSD noeliaSD added this to the 2.30.0 Beta milestone May 15, 2024
@noeliaSD noeliaSD removed their assignment May 15, 2024
@noeliaSD noeliaSD modified the milestones: 2.30.0 Beta, 2.31.0 Beta Jun 12, 2024
@noeliaSD noeliaSD modified the milestones: 2.31.0 Beta, 2.32.0 Beta Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants