Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All channels are folded and missing bold indicator of unread when updating to 2.29 #14886

Closed
anastasiyaig opened this issue May 23, 2024 · 6 comments · Fixed by #14911
Closed

All channels are folded and missing bold indicator of unread when updating to 2.29 #14886

anastasiyaig opened this issue May 23, 2024 · 6 comments · Fixed by #14911
Assignees
@jrainville
Labels
backend-team bug Something isn't working
Milestone
2.29.0 Beta

Comments

@anastasiyaig
Copy link
Contributor

anastasiyaig commented May 23, 2024 •
edited

Bug Report

Description

All channels are folded and missing bold indicator of unread when updating to 2.29

Steps to reproduce

  • Update to 2.29 rc 2
  • Check Status community

Expected behavior

  • categories with channels with unread messages are in bold
  • categories are not folded (same state as before the upgrade)

Actual behavior

Screenshot 2024-05-23 at 10 31 37

Additional Information

  • Status desktop version: 2.29 rc 2, also master
  • Operating System: macOS 14.4.1 (23E224)
@anastasiyaig anastasiyaig added bug Something isn't working ui-team labels May 23, 2024
@anastasiyaig anastasiyaig added this to the 2.29.0 Beta milestone May 23, 2024
@anastasiyaig
Copy link
Contributor Author

perhaps we can fix that for 2.29 for better user experience? It is not critical but just super visible

@anastasiyaig
Copy link
Contributor Author

@iurimatias could that be for 2.29? I marked it as such but feel free to deprioritise

@caybro
Copy link
Member

caybro commented May 23, 2024

Same in master fwiw

@anastasiyaig
Copy link
Contributor Author

ya, i just wonder if we need that fix in 2.29 now, or fix in master and then it will be present in 2.30

@jrainville
Copy link
Member

Ah I wanted to open this and forgot. Thanks ­for doing it @anastasiyaig

I think we should fix in 2.29. Especially the missing bold indicator is very annoying.

@jrainville
Copy link
Member

I'mm fairly sure it's a backend error with the models, so I'll assign my team

jrainville added a commit that referenced this issue May 23, 2024
@jrainville
fix(categories): fixes categories being always closed on start
341fcf0 
Part of #14886

The problem was that we converted `collapsed` to `opened` way too early and with a logic error.

By using collapsed until the module, it's way easier to understand and also fixes the logic mistakes.

I also renamed a couple of functions and variables so that the mistake doesn't happen again.
jrainville added a commit that referenced this issue May 23, 2024
@jrainville
fix(categories): fix category unread status
489ed2e 
Part of #14886

The problem was that the ChatDto doesn't have a categoryID, so we need to use the CommunityChat.

I think before, the channel groups had the full chat info, but not we can't rely on that.

The CommunityChat/Chat alignment refactor will simplify all of that #14219
@jrainville jrainville mentioned this issue May 23, 2024
Merged
jrainville added a commit that referenced this issue May 24, 2024
@jrainville
fix(categories): fixes categories being always closed on start
aa88dcd 
Part of #14886

The problem was that we converted `collapsed` to `opened` way too early and with a logic error.

By using collapsed until the module, it's way easier to understand and also fixes the logic mistakes.

I also renamed a couple of functions and variables so that the mistake doesn't happen again.
jrainville added a commit that referenced this issue May 24, 2024
@jrainville
fix(categories): fix category unread status
5a70b7e 
Part of #14886

The problem was that the ChatDto doesn't have a categoryID, so we need to use the CommunityChat.

I think before, the channel groups had the full chat info, but not we can't rely on that.

The CommunityChat/Chat alignment refactor will simplify all of that #14219
jrainville added a commit that referenced this issue May 24, 2024
@jrainville
fix(categories): fixes categories being always closed on start
34c3d5e 
Part of #14886

The problem was that we converted `collapsed` to `opened` way too early and with a logic error.

By using collapsed until the module, it's way easier to understand and also fixes the logic mistakes.

I also renamed a couple of functions and variables so that the mistake doesn't happen again.
jrainville added a commit that referenced this issue May 24, 2024
@jrainville
fix(categories): fix category unread status
78951a1 
Part of #14886

The problem was that the ChatDto doesn't have a categoryID, so we need to use the CommunityChat.

I think before, the channel groups had the full chat info, but not we can't rely on that.

The CommunityChat/Chat alignment refactor will simplify all of that #14219
@jrainville jrainville mentioned this issue May 24, 2024
Merged
@jrainville jrainville self-assigned this May 24, 2024
jrainville added a commit that referenced this issue May 27, 2024
@jrainville
fix(categories): fixes categories being always closed on start
6a820c9 
Part of #14886

The problem was that we converted `collapsed` to `opened` way too early and with a logic error.

By using collapsed until the module, it's way easier to understand and also fixes the logic mistakes.

I also renamed a couple of functions and variables so that the mistake doesn't happen again.
jrainville added a commit that referenced this issue May 27, 2024
@jrainville
fix(categories): fix category unread status
9523e6b 
Part of #14886

The problem was that the ChatDto doesn't have a categoryID, so we need to use the CommunityChat.

I think before, the channel groups had the full chat info, but not we can't rely on that.

The CommunityChat/Chat alignment refactor will simplify all of that #14219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
backend-team bug Something isn't working
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.29.0 Beta
Development

Successfully merging a pull request may close this issue.

[CHERRY PICK] category fixes status-im/status-desktop
3 participants
@caybro @jrainville @anastasiyaig