Fix 2 category issues (always collapsed and missing bold) #14895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #14886 The problem was that we converted `collapsed` to `opened` way too early and with a logic error. By using collapsed until the module, it's way easier to understand and also fixes the logic mistakes. I also renamed a couple of functions and variables so that the mistake doesn't happen again.
Jenkins Builds
|
MishkaRogachev
approved these changes
May 23, 2024
kounkou
approved these changes
May 24, 2024
|
Nice refactor, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14886
Fixes categories being always closed on start
The problem was that we converted
collapsedtoopenedway too early and with a logic error.By using collapsed until the module, it's way easier to understand and also fixes the logic mistakes.
I also renamed a couple of functions and variables so that the mistake doesn't happen again.
Fix category unread status
The problem was that the ChatDto doesn't have a categoryID, so we need to use the CommunityChat.
I think before, the channel groups had the full chat info, but not we can't rely on that.
The CommunityChat/Chat alignment refactor will simplify all of that #14219