Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TokenSelector] Duplicate plain token entries #15412

Closed
Tracked by #14786
caybro opened this issue Jul 1, 2024 · 0 comments · Fixed by #15413
Closed
Tracked by #14786

[TokenSelector] Duplicate plain token entries #15412

caybro opened this issue Jul 1, 2024 · 0 comments · Fixed by #15413
Assignees
@caybro
Labels
E:D Swap M1 Implement Swap operations ui-team
Milestone
2.30.0 Beta

Comments

@caybro
Copy link
Member

caybro commented Jul 1, 2024 •
edited
Loading

image

Filter out duplicate plain token entries
@caybro caybro mentioned this issue Jul 1, 2024
Open
18 tasks
@caybro caybro self-assigned this Jul 1, 2024
@caybro caybro added this to the 2.30.0 Beta milestone Jul 1, 2024
@caybro caybro added ui-team E:D Swap M1 Implement Swap operations labels Jul 1, 2024
caybro added a commit that referenced this issue Jul 1, 2024
@caybro
fix(TokenSelector): Duplicate plain token entries
554c44f 
- filter out plain tokens from the adaptor's if already present in the
output model
- add a corresponding regression test

Fixes #15412
@caybro caybro mentioned this issue Jul 1, 2024
Merged
1 task
@caybro caybro linked a pull request Jul 1, 2024 that will close this issue
fix(TokenSelector): Duplicate plain token entries #15413
Merged
1 task
@caybro caybro closed this as completed in 464af7a Jul 2, 2024
Valentina1133 pushed a commit that referenced this issue Jul 5, 2024
@caybro @Valentina1133
fix(TokenSelector): Duplicate plain token entries
faf1b4c 
- filter out plain tokens from the adaptor's if already present in the
output model
- add a corresponding regression test

Fixes #15412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caybro caybro

Labels
E:D Swap M1 Implement Swap operations ui-team
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.30.0 Beta
Development

Successfully merging a pull request may close this issue.

fix(TokenSelector): Duplicate plain token entries status-im/status-desktop
1 participant
@caybro