Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Sign and Approve modals into SwapModal #15443

Open
Tracked by #14786
Khushboo-dev-cpp opened this issue Jul 3, 2024 · 2 comments
Open
Tracked by #14786

Integrate Sign and Approve modals into SwapModal #15443

Khushboo-dev-cpp opened this issue Jul 3, 2024 · 2 comments
Assignees
@caybro
Labels
E:D Swap M1 Implement Swap operations feature swap-team ui-team
Milestone
2.30.0 Beta

Comments

@Khushboo-dev-cpp
Copy link
Contributor

Khushboo-dev-cpp commented Jul 3, 2024 •
edited by caybro
Loading

We need to integrate sign modal created here into swap #15410, as well as approve, created here: #15460
@Khushboo-dev-cpp Khushboo-dev-cpp mentioned this issue Jul 3, 2024
Open
18 tasks
@noeliaSD
Copy link
Contributor

noeliaSD commented Jul 3, 2024 •
edited
Loading

Ideally it shold be covered by #14785. cc: @caybro

@caybro
Copy link
Member

caybro commented Jul 3, 2024

Ideally it shold be covered by #14785. cc: @caybro

I'd rather keep it under a separate task

@caybro caybro self-assigned this Jul 3, 2024
@caybro caybro added this to the 2.30.0 Beta milestone Jul 4, 2024
caybro added a commit that referenced this issue Jul 4, 2024
@caybro
feat:[UI - Swap] Create swap approve dialog
df58602 
- create a new UI component
- add it to StoryBook
- TODO: add QML tests
- integration will be done as part of
#15443

Fixes #15442
@caybro caybro mentioned this issue Jul 4, 2024
Open
1 task
@caybro caybro changed the title Integrate Sign modal into Swap Integrate Sign and Approve modals into SwapModal Jul 4, 2024
caybro added a commit that referenced this issue Jul 4, 2024
@caybro
feat:[UI - Swap] Create swap approve dialog
4c0c77d 
- create a new UI component
- add it to StoryBook
- TODO: add QML tests
- integration will be done as part of
#15443

Fixes #15442
caybro added a commit that referenced this issue Jul 4, 2024
@caybro
feat:[UI - Swap] Create swap approve dialog
5c058e7 
- create a new UI component
- add it to StoryBook
- add QML tests
- integration will be done as part of
#15443

Fixes #15442
caybro added a commit that referenced this issue Jul 4, 2024
@caybro
feat:[UI - Swap] Create swap approve dialog
3923a31 
- create a new UI component
- add it to StoryBook
- add QML tests
- integration will be done as part of
#15443

Fixes #15442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caybro caybro

Labels
E:D Swap M1 Implement Swap operations feature swap-team ui-team
Projects
Status Desktop/Mobile Board
Status: Next iteration
Milestone
2.30.0 Beta
Development

No branches or pull requests
3 participants
@caybro @Khushboo-dev-cpp @noeliaSD