Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot join community from the invitation #6712

Closed
micieslak opened this issue Jul 29, 2022 · 5 comments
Closed

Cannot join community from the invitation #6712

micieslak opened this issue Jul 29, 2022 · 5 comments
Labels
bug Something isn't working to analyze
Milestone

Comments

@micieslak
Copy link
Member

Bug Report

Clicking "Join" in the bubble in the chat has no effect.

Steps to reproduce

Invite users, login as the use who was invited, click "Join" in the direct chat.

Expected behavior

Community view should be opened.

Actual behavior

Nothing happens

Screencast.2022-07-29.11.24.12.mp4

Additional Information

  • Status desktop version:
  • Operating System: Ubuntu
@micieslak micieslak added bug Something isn't working E:Communities labels Jul 29, 2022
@borismelnik borismelnik self-assigned this Aug 1, 2022
@borismelnik
Copy link
Contributor

So basically, it can be cos you use an old version of status-go. I checked it and I can reproduce it on some old version phase4 from last dogfooding session, but can't reproduce it on new one. Based on new logic, Join button should be removed. Please try to reproduce it on latest status-go version.

@elina2015
Copy link

@borismelnik @iurimatias I tested this issue on the latest master and the bug is stably reproduced. Could we move this bug for fixing?

@borismelnik
Copy link
Contributor

Now I understand it. It happens cos we still not process rejected requests. I request was rejected - we can't resend it even if sender sent new invitation cos request still Pending. I think, the solution for it is add new method to status-go like myRejectedJoinCommunityRequests (which is similar as myPendingJoinCommunityRequest) and update current list of pending requests.

@iurimatias
Copy link
Member

to be reviewed after #7072

@iurimatias
Copy link
Member

no longer seems to happen, also will issue is no longer valid after new join workflow

@iurimatias iurimatias added this to the 0.9.0 milestone Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working to analyze
Projects
Archived in project
Development

No branches or pull requests

4 participants