Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New join community workflow #7072

Closed
9 of 10 tasks
iurimatias opened this issue Aug 17, 2022 · 1 comment
Closed
9 of 10 tasks

New join community workflow #7072

iurimatias opened this issue Aug 17, 2022 · 1 comment

Comments

@iurimatias
Copy link
Member

iurimatias commented Aug 17, 2022

Description

figma: https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?node-id=2312%3A298851
feature spec: https://github.com/status-im/feature-specs/pull/79/files

out of scope:

  • token based permissions IS OUT OF SCOPE FOR THIS TASK
  • hcaptcha

goal: implement the various features & changes present in the workflow in figma:

  • Should be possible to view a community without being a member (but not send messages)
  • Button to join community if community doesn't require membership approval
  • Button to request to join community if community requires membership approval
  • Modify welcome modal to be as in the design (note buttons are different depending if it's to join a community or to request joining one)
  • User should see an ephermeral notification that a request has been made
  • User should see an ephermeral notification that a request has been accepted or rejected
  • Community Request should be present in activity center #8313
  • User should be able to cancel an ongoing membership request
  • Community invites in chat should still work as expected
  • Squish tests might need to be updated or made for this
borismelnik added a commit that referenced this issue Sep 7, 2022
@John-44
Copy link

John-44 commented Sep 14, 2022

(copying a comment into this issue as this comment contains pictures that describe what's needed a bit clearer)


@iurimatias @osmaczko @faust4exe @jrainville The behaviour shown in this screencast is incorrect.

186612309-384de00d-8967-44ec-8d5b-c599352214ae.mp4

When the user in the right screen clicks "Request Access" (btw this button text should be changed to "Go to Community" in all cases), a popup should not appear.

Instead the user should be redirected to the home screen for the community:

  1. If the Community is an open community (e.g. no token permissions at the community level) and if 'manual membership approval' is set to No, then the user should see this:
    2022-09-14 11_00_16-Window
    (link to figma https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?node-id=2244%3A260547 )

  2. If the Community is an open community (e.g. no token permissions at the community level) and if 'manual membership approval' is set to Yes, then the user should see this:
    2022-09-14 11_01_26-Window
    (link to figma https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?node-id=2365%3A296006 )

  3. If the Community is a closed community (e.g. there are token permissions at the community level) and if 'manual membership approval' is set to No, then the user should see this if they hold the tokens needed to access the community:
    2022-09-14 11_03_11-Window
    (link to figma https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?node-id=2314%3A257946 )

  4. If the Community is a closed community (e.g. there are token permissions at the community level) and if 'manual membership approval' is set to No, then the user should see this if they do not hold the tokens needed to access the community:
    2022-09-14 11_04_21-Window
    (link to figma https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?node-id=2367%3A280302 )

  5. If the Community is a closed community (e.g. there are token permissions at the community level) and if 'manual membership approval' is set to Yes, then the user should see this if they hold the tokens needed to access the community:
    2022-09-14 11_05_39-Window
    (link to figma https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?node-id=2365%3A317460 )

  6. If the Community is a closed community (e.g. there are token permissions at the community level) and if 'manual membership approval' is set to Yes, then the user should see this if they do not hold the tokens needed to access the community:
    2022-09-14 11_06_52-Kuba⎜Desktop – Figma
    (link to figma https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?node-id=2365%3A317901)

osmaczko added a commit to status-im/status-go that referenced this issue Sep 22, 2022
- added `SpectateCommunity` endpoint, it is supposed to be used in
  scenarios where we want to "Go to public Community" and see its
  content without joining
- added `spectated` field to `Community`, it means we are observing the
  community and its chats but we are not members

Use case:
status-im/status-desktop#7072 (comment)
osmaczko added a commit that referenced this issue Sep 22, 2022
- user is able to see community without being a member
- invitation bubble always display "Go to Community"
- join community buttons are displayed in community view

main part of: #7072
osmaczko added a commit to status-im/status-go that referenced this issue Sep 23, 2022
- added `SpectateCommunity` endpoint, it is supposed to be used in
  scenarios where we want to "Go to public Community" and see its
  content without joining
- added `spectated` field to `Community`, it means we are observing the
  community and its chats but we are not members

Use case:
status-im/status-desktop#7072 (comment)
osmaczko added a commit to status-im/status-go that referenced this issue Sep 23, 2022
- added `SpectateCommunity` endpoint, it is supposed to be used in
  scenarios where we want to "Go to public Community" and see its
  content without joining
- added `spectated` field to `Community`, it means we are observing the
  community and its chats but we are not members

Use case:
status-im/status-desktop#7072 (comment)
osmaczko added a commit that referenced this issue Sep 23, 2022
- user is able to see community without being a member
- invitation bubble always display "Go to Community"
- join community buttons are displayed in community view

main part of: #7072
@iurimatias iurimatias modified the milestone: 0.7.0 Sep 28, 2022
borismelnik added a commit that referenced this issue Oct 26, 2022
borismelnik added a commit that referenced this issue Oct 26, 2022
borismelnik added a commit that referenced this issue Oct 27, 2022
borismelnik added a commit that referenced this issue Oct 27, 2022
borismelnik added a commit that referenced this issue Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants