fix: Adding Beta user agreement #11100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (19)
|
alexjba
force-pushed
the
11044-new-beta-dialog-design-to-be-presented-every-time-user-launches-status-in-beta
branch
from
66997aa
to
d208584
Compare
micieslak
requested changes
Jun 15, 2023
There was a problem hiding this comment.
Please add proper sizing to text component (like Layout.fillWidth: true) to have proper layout no matter how long text we have.
Here the text is extended on purpose, similar situation may happen for translations.
Btw. things like that can be easily check with the inspection tool (but it's temporarily broken for popups - #11111)
|
|
||
| UserAgreementPopup { | ||
| id: popup | ||
| visible: true |
There was a problem hiding this comment.
please add for convenience:
anchors.centerIn: parent
modal: false
d208584
to
a5fc1c0
Compare
Fixed. I've added wordWrap to the text paragraph and Layout.fillWidth to the checkboxes. Looks good now with large text. |
micieslak
approved these changes
Jun 16, 2023
| Layout.preferredWidth: 64 | ||
| Layout.preferredHeight: 64 | ||
| Layout.alignment: Qt.AlignHCenter | ||
| image.source: Style.png("status-logo") |
There was a problem hiding this comment.
adding image.mipmap: true here improves quality a bit bc the original image is much bigger than 64x64
| Layout.fillWidth: true | ||
| Layout.topMargin: -10 //reduced margin by design | ||
| Layout.bottomMargin: layout.spacing | ||
| contentItem: Paragraph { |
There was a problem hiding this comment.
maybe
Layout.fillWidth: true
Layout.fillHeight: true
could be moved from Paragraph to AgreementSection bc in this context those attached properties make no sense.
storybook/figma.json
Outdated
| @@ -212,5 +212,8 @@ | |||
| "https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?type=design&node-id=29528%3A588403&t=GUxMZEWcfRO7pXJb-1", | |||
| "https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?type=design&node-id=29528%3A588563&t=GUxMZEWcfRO7pXJb-1", | |||
| "https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?type=design&node-id=29528%3A587660&t=GUxMZEWcfRO7pXJb-1" | |||
| ], | |||
| "UserAgreementPopup": [ | |||
| "https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba⎜Desktop?type=design&node-id=1023-298171&t=Q4MOViPCoHsTjhs6-0" | |||
There was a problem hiding this comment.
the link seems to be wrong/outdated
alexjba
force-pushed
the
11044-new-beta-dialog-design-to-be-presented-every-time-user-launches-status-in-beta
branch
from
a5fc1c0
to
822c85d
Compare
alexjba
force-pushed
the
11044-new-beta-dialog-design-to-be-presented-every-time-user-launches-status-in-beta
branch
from
822c85d
to
dfc9f7e
Compare
alexjba
deleted the
11044-new-beta-dialog-design-to-be-presented-every-time-user-launches-status-in-beta
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Closing: #11044
Changes:
Affected areas
AppMain
Screenshot of functionality (including design for comparison)