maintenance bumps #13117
Merged
maintenance bumps #13117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (7)
|
Maintenance bumps of several dependencies - broadly address security issues, 1.6+ compatibility, bugfixes etc to catch up with Nimbus' development The extra try/catch is due to increased exception safety requirements in `chronicles`, where `fmt` allows dynamic format strings and therefore may raise `ValueError` in theory.
jrainville
approved these changes
Feb 14, 2024
|
@anastasiyaig can you get someone from you team to test this PR. See if it's still stable all around |
|
hey @jrainville i launched our regression pack for this PR. the results are very good . 1 test failed and it is the same test failed today in nightly. |
|
Awesome, then when @alaibe gives his thumbs up, we can merge (or wait after the RC creation) |
|
fwiw, these are the trivial low-risk bumps - after this, there are a few more in store that focus on particular libraries that might need a few more changes here and there because their API has evolved - that said, I'd recommend this PR at least goes in since there are cryptography library upgrades that improve security. |
alaibe
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintenance bumps of several dependencies - broadly address security issues, 1.6+ compatibility, bugfixes etc to catch up with Nimbus' development
The extra try/catch is due to increased exception safety requirements in
chronicles, wherefmtallows dynamic format strings and therefore may raiseValueErrorin theory.