Activity dynamic updates integration #13127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (200)
|
stefandunca
force-pushed
the
activity_dynamic_updates-12120
branch
5 times, most recently
from
5099d5c
to
603e68e
Compare
stefandunca
force-pushed
the
activity_dynamic_updates-12120
branch
from
a2b6d09
to
469d7bb
Compare
stefandunca
force-pushed
the
activity_dynamic_updates-12120
branch
4 times, most recently
from
460e0c0
to
18b4032
Compare
stefandunca
changed the title
Merged
1 task
stefandunca
changed the base branch from
master
to
test_activity_update-12120
stefandunca
force-pushed
the
activity_dynamic_updates-12120
branch
from
18b4032
to
d63e561
Compare
stefandunca
force-pushed
the
test_activity_update-12120
branch
2 times, most recently
from
cdc6d28
to
e6cee19
Compare
stefandunca
force-pushed
the
activity_dynamic_updates-12120
branch
5 times, most recently
from
9426e90
to
5875ebf
Compare
stefandunca
changed the base branch from
master
to
sql_filter_integration_test-12120
stefandunca
force-pushed
the
activity_dynamic_updates-12120
branch
from
5875ebf
to
ceba6fd
Compare
stefandunca
force-pushed
the
sql_filter_integration_test-12120
branch
from
85b614f
to
b2daf23
Compare
stefandunca
force-pushed
the
activity_dynamic_updates-12120
branch
2 times, most recently
from
c1953ad
to
b75b9e3
Compare
stefandunca
force-pushed
the
sql_filter_integration_test-12120
branch
from
b2daf23
to
4990d1f
Compare
stefandunca
force-pushed
the
activity_dynamic_updates-12120
branch
from
b75b9e3
to
abf7ca6
Compare
stefandunca
force-pushed
the
sql_filter_integration_test-12120
branch
from
4990d1f
to
6d47531
Compare
stefandunca
force-pushed
the
activity_dynamic_updates-12120
branch
3 times, most recently
from
5b5379a
to
308685a
Compare
stefandunca
requested review from
dlipicar,
Cuteivist,
alaibe and
anastasiyaig
stefandunca
force-pushed
the
activity_dynamic_updates-12120
branch
from
9a92062
to
fcfdadd
Compare
Cuteivist
approved these changes
Feb 21, 2024
dlipicar
reviewed
Feb 22, 2024
dlipicar
approved these changes
Feb 22, 2024
stefandunca
force-pushed
the
activity_dynamic_updates-12120
branch
from
fcfdadd
to
3daed67
Compare
stefandunca
force-pushed
the
activity_dynamic_updates-12120
branch
from
3daed67
to
8f0d74f
Compare
|
@lukaszso in the latest update I fixed the reported corner case when clearing filter after a new transactions reset. Please check and report also on the other workflows that were remaining to check. Thanks! |
stefandunca
force-pushed
the
activity_dynamic_updates-12120
branch
from
8f0d74f
to
5d93d52
Compare
Switch the activity filter to use the new session-based API that deliver incremental updates to the current filter. Drop the old quick win listening for individual change events and use the unified API instead. The new transactions (on-top) trigger the old "new transactions" buttons that trigger reset of the current filter and the top new transacitons highlighted. Highlight mixed changes (not new on top) as they come in Highlight new changes on filter reset Closes #12120
stefandunca
force-pushed
the
activity_dynamic_updates-12120
branch
from
5d93d52
to
a8ad595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12120
Switch the activity filter to use the new session-based API, which provides incremental updates to the current filter.
Replace the previous method of listening for individual change events with this unified API that delivers all the updates at filter entry level.
The new transactions now activate the "new transactions" button, causing a reset of the current filter and highlighting the top new transactions.
New entries (pulled by downloader) older than the latest visible entries are inserted in the view and highlithed
On all filter clear the updates made while the filter was active are highlighted
New transactions (on top)
Screen.Recording.2024-02-08.at.00.16.09.mov
New transactions (mixed with existing)
mixed_animation.mov
Clean filter updates
clear_filter_updates.mov