Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UserListPanel): use FastExpressionRole #13299

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix(UserListPanel): use FastExpressionRole #13299

merged 1 commit into from
Mar 14, 2024

Conversation

igor-sirotin
Copy link
Contributor

@igor-sirotin igor-sirotin commented Jan 25, 2024 •
edited

Related to #13354

What does the PR do

As @caybro proposed here: #12363 (comment), I replaced ExpressionRole with FastExpressionRole, it helped.

As noted in comments, this doesn't fix the issue. But should be there anyway.
#13299 (comment)

@status-im-auto
Copy link
Member

status-im-auto commented Jan 25, 2024 •
edited

Jenkins Builds

Click to see older builds (7)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f785878 #1 2024-01-25 15:18:22 ~5 min tests/nim 📄log
✔️ f785878 #1 2024-01-25 15:19:48 ~6 min macos/aarch64 🍎dmg
✔️ f785878 #1 2024-01-25 15:23:29 ~10 min tests/ui 📄log
✔️ f785878 #1 2024-01-25 15:25:47 ~12 min macos/x86_64 🍎dmg
✔️ f785878 #1 2024-01-25 15:32:36 ~19 min linux/x86_64 📦tgz
✔️ f785878 #1 2024-01-25 15:38:39 ~25 min windows/x86_64 💿exe
✔️ f785878 #1 2024-01-25 15:44:11 ~31 min tests/e2e 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c9650aa #2 2024-01-26 15:38:46 ~6 min tests/nim 📄log
✔️ c9650aa #2 2024-01-26 15:38:53 ~6 min macos/aarch64 🍎dmg
✔️ c9650aa #2 2024-01-26 15:40:44 ~7 min macos/x86_64 🍎dmg
✔️ c9650aa #2 2024-01-26 15:44:24 ~11 min tests/ui 📄log
✔️ c9650aa #2 2024-01-26 15:51:38 ~18 min linux/x86_64 📦tgz
✔️ c9650aa #2 2024-01-26 15:54:05 ~21 min windows/x86_64 💿exe
✖️ c9650aa #2 2024-01-26 16:05:55 ~33 min tests/e2e 📄log
✔️ 5fc0aff #3 2024-03-12 16:12:23 ~6 min tests/nim 📄log
✔️ 5fc0aff #3 2024-03-12 16:16:17 ~10 min macos/aarch64 🍎dmg
✔️ 5fc0aff #3 2024-03-12 16:17:26 ~11 min tests/ui 📄log
✔️ 5fc0aff #3 2024-03-12 16:18:12 ~12 min macos/x86_64 🍎dmg
✔️ 5fc0aff #3 2024-03-12 16:22:16 ~16 min linux/x86_64 📦tgz
✔️ 5fc0aff #3 2024-03-12 16:30:14 ~24 min windows/x86_64 💿exe

This was referenced Jan 29, 2024
Closed
Closed
Closed
@igor-sirotin igor-sirotin changed the title fix: delay when switching animation fix(UserListPanel): use FastExpressionRole Mar 12, 2024
caybro
caybro approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ofc 😄

@igor-sirotin
Copy link
Contributor Author

@caybro can you please ping someone from ui team to review this? 🙂

alexjba
alexjba approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@caybro
Copy link
Member

caybro commented Mar 14, 2024

@caybro can you please ping someone from ui team to review this? 🙂

Magic 🧙‍♂️

@igor-sirotin igor-sirotin merged commit da41057 into master Mar 14, 2024
8 checks passed
@igor-sirotin igor-sirotin deleted the fix/issue-12363 branch March 14, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caybro caybro caybro approved these changes

@alexjba alexjba alexjba approved these changes

@micieslak micieslak Awaiting requested review from micieslak

@alexandraB99 alexandraB99 Awaiting requested review from alexandraB99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@igor-sirotin @status-im-auto @caybro @alexjba