Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing clusterID in node config #13364

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: missing clusterID in node config #13364

merged 1 commit into from
Feb 5, 2024

Conversation

richard-ramos
Copy link
Member

Fixes #13355

The clusterID was not being sent when a change related to the node config was executed.
This issue is related to #12918 and should be fixed once proper endpoints for status-go node configuration changes are created

@status-im-auto
Copy link
Member

status-im-auto commented Jan 30, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 55087e6 #1 2024-01-30 19:56:33 ~5 min tests/nim 📄log
✔️ 55087e6 #1 2024-01-30 19:57:44 ~6 min macos/aarch64 🍎dmg
✖️ 55087e6 #1 2024-01-30 20:01:36 ~10 min tests/e2e 📄log
✔️ 55087e6 #1 2024-01-30 20:01:44 ~10 min tests/ui 📄log
✔️ 55087e6 #1 2024-01-30 20:03:07 ~12 min macos/x86_64 🍎dmg
✔️ 55087e6 #1 2024-01-30 20:07:40 ~16 min linux/x86_64 📦tgz
✔️ 55087e6 #1 2024-01-30 20:23:36 ~32 min windows/x86_64 💿exe
✖️ 55087e6 #2 2024-01-30 20:38:42 ~33 min tests/e2e 📄log
✖️ 55087e6 #3 2024-02-05 12:32:09 ~8 min tests/e2e 📄log
✔️ 55087e6 #4 2024-02-05 13:06:28 ~30 min tests/e2e 📄log

Copy link
Contributor

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I thought this thing is fleet-dependant 🤔

@richard-ramos
Copy link
Member Author

Yes; the fleet details are still stored in the node config, and for some operations in desktop we modify the node config directly - i.e., switching the log level -, so if the node config object in desktop, is missing the clusterID, when we sent the new node config to status-go, it will store the clusterID with a 0, since it will use the default value, instead of using the correct clusterID which was stored in the node config before changing the log level.

@richard-ramos richard-ramos merged commit 0dd07a8 into master Feb 5, 2024
9 checks passed
@richard-ramos richard-ramos deleted the fix/cluster-id branch February 5, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Connection to store node is lost
5 participants