feat(@wallet): 5 chars min account keypair name #13414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
caybro
requested changes
Feb 5, 2024
ui/imports/shared/popups/addaccount/states/EnterKeypairName.qml
Outdated
Show resolved
Hide resolved
| @@ -88,6 +88,13 @@ Item { | |||
| root.store.addAccountModule.newKeyPairName = text | |||
| } | |||
|
|
|||
| validators: [ | |||
| StatusMinLengthValidator { | |||
| errorMessage: qsTr("Keypair name must be at least %1 characters").arg(Constants.addAccountPopup.keyPairAccountNameMinLength) | |||
There was a problem hiding this comment.
Given the amount of repetition, extract the whole Validator somewhere? :)
There was a problem hiding this comment.
I'd vote for a AccountNameInput and KeypairNameInput.
Many other things are repeated
If you agree i ll create the issue
stefandunca
approved these changes
Feb 5, 2024
alaibe
force-pushed
the
feat/5-chars-min-account-name
branch
from
ee6c712
to
ac44483
Compare
caybro
approved these changes
Feb 6, 2024
This was referenced Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13384