feat(@desktop/settings): Integrate token advanced settings with backend #13487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuteivist
requested review from
caybro,
micieslak,
Khushboo-dev-cpp and
noeliaSD
Jenkins BuildsClick to see older builds (26)
|
caybro
reviewed
Feb 9, 2024
Cuteivist
force-pushed
the
feat/13178-token-advanced-settings
branch
from
ad8df75
to
52be63c
Compare
caybro
approved these changes
Feb 12, 2024
alaibe
approved these changes
Feb 12, 2024
|
@Cuteivist can you please rebase so tests can pass? there were some UI changes merged recently |
Cuteivist
force-pushed
the
feat/13178-token-advanced-settings
branch
from
52be63c
to
bdcda4c
Compare
|
its all green now :) |
noeliaSD
reviewed
Feb 14, 2024
There was a problem hiding this comment.
Code LGTM! I've just added a question for Ben.
I'd also like to test it. @Cuteivist could you rebase on top of master? I cannot test it now bc there was a bug on master yesterday that doesn't allow to save changes using the dirty toast message!
Cuteivist
force-pushed
the
feat/13178-token-advanced-settings
branch
from
bdcda4c
to
d7f219e
Compare
@noeliaSD Code is rebased to newest master. To properly get it working you need to rebase status-go to |
Cuteivist
force-pushed
the
feat/13178-token-advanced-settings
branch
from
d7f219e
to
3991e9f
Compare
Cuteivist
force-pushed
the
feat/13178-token-advanced-settings
branch
from
3991e9f
to
9068cb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task #13178
What does the PR do
CurrencyAmountas Controller variable because it was removed by garbage collectorAffected areas
Settings / Token Management / Advanced
Screenshot of functionality (including design for comparison)
2024-02-09_11-36-06.mp4