Send dialog: sizing and layout rules to limit dialog height jumping between states #13532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khushboo-dev-cpp
force-pushed
the
feat/#13377
branch
from
deae925
to
3b5e219
Compare
Khushboo-dev-cpp
changed the title
Jenkins BuildsClick to see older builds (36)
|
Khushboo-dev-cpp
force-pushed
the
feat/#13377
branch
7 times, most recently
from
7d8c652
to
b511e0c
Compare
Khushboo-dev-cpp
requested review from
alaibe,
dlipicar,
micieslak,
stefandunca,
Cuteivist and
saledjenic
Khushboo-dev-cpp
force-pushed
the
feat/#13377
branch
from
b511e0c
to
b940f9c
Compare
|
Is it just me or the background shade on the per-chain values looks weird? It seems not to be positioned properly. I cannot find that in Figma actually |
However this is an issue that existed before my changes, we probably need to ask Ben and get designs on how to handle this small scrolling area here. |
alaibe
approved these changes
Feb 18, 2024
dlipicar
reviewed
Feb 19, 2024
dlipicar
approved these changes
Feb 19, 2024
Khushboo-dev-cpp
force-pushed
the
feat/#13377
branch
from
b940f9c
to
778600d
Compare
thanks for the hint, TokenListViewPage was indeed broken. Ive fixed it now :) |
caybro
approved these changes
Feb 19, 2024
| } | ||
|
|
||
| // Horizontal spacer | ||
| RowLayout {} |
There was a problem hiding this comment.
That's a weird way to have a spacer
…dialog height jumping between states fixes #13377
Khushboo-dev-cpp
force-pushed
the
feat/#13377
branch
from
778600d
to
51c39a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13377
What does the PR do
Applies the new sizing rules for SendModal as per design https://www.figma.com/file/FkFClTCYKf83RJWoifWgoX/Wallet-v2?type=design&node-id=21233-57676&mode=design&t=2O68lxNGG9g1b1tx-4
Please note even though the code looks like its been touched a lot, its only been rearranged or the container has been changed
Affected areas
SendModal
StatusQ checklist
Screenshot of functionality (including design for comparison)
SendModalSizing.mov