feat(@wallet): update collectibles model only with changes #13544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (16)
|
dlipicar
force-pushed
the
feat/13254-granular-collectibles-model-updates
branch
from
ca07f71
to
1759c77
Compare
alaibe
approved these changes
Feb 14, 2024
caybro
reviewed
Feb 16, 2024
| for idx in oldIndicesToRemove: | ||
| let updatedIdx = idx - removedItems | ||
| self.removeCollectibleItem(updatedIdx) | ||
| removedItems += 1 |
There was a problem hiding this comment.
Why are you counting the removedItems?
There was a problem hiding this comment.
oldIndicesToRemove holds the indices of the original list in ascending order. Every time we delete an item from the list, we should subtract 1 from the remaining indices in oldIndicesToRemove. Instead of doing that I just keep track of how many items I've removed and do updatedIdx = idx - removedItems.
noeliaSD
approved these changes
Feb 16, 2024
dlipicar
force-pushed
the
feat/13254-granular-collectibles-model-updates
branch
from
1759c77
to
8c4cb41
Compare
dlipicar
force-pushed
the
feat/13254-granular-collectibles-model-updates
branch
from
8c4cb41
to
feac74d
Compare
|
@dlipicar i will check on failed tests on monday first thing. For now i see that some locator is missing for editing community, not sure what happens (it was passing today against master many times) |
dlipicar
force-pushed
the
feat/13254-granular-collectibles-model-updates
branch
from
feac74d
to
acce277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13254
What does the PR do
Whenever a change in the list of owned collectibles is reported by status-go, we now update the model with the delta (added/removed items) instead of doing a full reset, which should help avoid doing unnecessary work in the SFPM.
This is a straightforward approach, and there's room for improvement still: