Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/13385/community permissions issues #13573

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

osmaczko
Copy link
Contributor

What does the PR do

fixes: #13385

Affected areas

  • community permissions

Screenshot of functionality (including design for comparison)

missing-permissions-2024-02-15_12.55.14.mp4

@status-im-auto
Copy link
Member

status-im-auto commented Feb 15, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 53ef9d6 #1 2024-02-15 12:09:25 ~5 min tests/nim 📄log
✔️ 53ef9d6 #1 2024-02-15 12:11:24 ~7 min macos/aarch64 🍎dmg
✔️ 53ef9d6 #1 2024-02-15 12:13:59 ~10 min macos/x86_64 🍎dmg
✔️ 53ef9d6 #1 2024-02-15 12:15:09 ~11 min tests/ui 📄log
✔️ 53ef9d6 #1 2024-02-15 12:21:01 ~17 min linux/x86_64 📦tgz
✔️ 53ef9d6 #1 2024-02-15 12:37:28 ~33 min windows/x86_64 💿exe

Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the part in communities/modules. I thought the tokens were only needed by owners to show in the admin panel

@@ -700,6 +700,12 @@ QtObject:
permissionUpdated = true
break

if tokenPermission.chatIds.len == prevTokenPermission.chatIds.len:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to split this function into smaller ones some day.

@osmaczko osmaczko merged commit a2b8c3d into master Feb 16, 2024
8 checks passed
@osmaczko osmaczko deleted the fix/13385/community-permissions-issues branch February 16, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues when joining a Community with channel permissions
4 participants