feat(ProfileShowcase): Add foldable sections in all needed settings tabs #13592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om wallet to shared Renamed `ManageTokensListViewBase` to `EmptyShapeRectangleFooterListView` and moved `FoldableHeader` to shared/controls. Updated related `ManageXXPanel` components.
Removed unnecessary `ColumnLayout` and adjusted sizing of component inside.
Jenkins Builds
|
alexjba
approved these changes
Feb 16, 2024
caybro
reviewed
Feb 16, 2024
micieslak
approved these changes
Feb 16, 2024
Yeah, not related to this pr. After the model's refactor we can review it again! |
- Modified `ProfileShowcasePanel` with 2 foldable sections. - Modified api of `ProfileShowcaseCommunitiesPanel` with the new base component. - Modified api of `ProfileShowcaseAccountsPanel` with the new base component. - Modified api of `ProfileShowcaseAssetsPanel` and `ProfileShowcaseCollectiblesPanel` with the new base component. - Added needed `storybook` support. Closes of #13504
noeliaSD
force-pushed
the
feat/issue-13504
branch
from
05b98e3
to
88854a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13504
What does the PR do
ProfileShowcaseBasePanelwith 2 foldable sections.ProfileShowcaseXXXPanelwith the new base component (communities, accounts, assets and collectibles).storybooksupport.NOTES:
EmptyShapeRectangleFooterListViewcontains a new propertyemptythat must be removed when refactor of the hidden / showcase models are done in [Profile Showcase]: simplify API ofProfileShowcase*Paneltabs #13498appare not working properly in some occasions due to how the models are threated now. Same thing than the previous one, with the models refactor, it will be solved.Affected areas
Profile showcase tabs: Accounts, Communities, Collectibles and Assets
Screenshot of functionality
Screen.Recording.2024-02-15.at.18.17.17.mov
Screen.Recording.2024-02-15.at.19.24.12.mov
Screen.Recording.2024-02-16.at.09.42.03.mov