Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Profile flow): Mark as untrusted #13611

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

caybro
Copy link
Member

@caybro caybro commented Feb 16, 2024

What does the PR do

  • add new popup for marking a person as untrusted
  • optionally display checkboxes to remove ID verification or the contact
  • emit toasts

Fixes #13520

Affected areas

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

image

@caybro caybro linked an issue Feb 16, 2024 that may be closed by this pull request
@status-im-auto
Copy link
Member

status-im-auto commented Feb 16, 2024

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 57d8b13 #1 2024-02-16 17:42:34 ~6 min tests/nim 📄log
✔️ 57d8b13 #1 2024-02-16 17:46:28 ~10 min macos/x86_64 🍎dmg
✔️ 57d8b13 #1 2024-02-16 17:47:03 ~10 min tests/ui 📄log
✔️ 57d8b13 #1 2024-02-16 17:49:47 ~13 min macos/aarch64 🍎dmg
✔️ 57d8b13 #1 2024-02-16 17:53:08 ~16 min linux/x86_64 📦tgz
✔️ 57d8b13 #1 2024-02-16 18:01:16 ~24 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3e8fa0d #2 2024-02-19 10:27:57 ~4 min macos/aarch64 🍎dmg
✔️ 3e8fa0d #2 2024-02-19 10:29:28 ~5 min tests/nim 📄log
✔️ 3e8fa0d #2 2024-02-19 10:31:40 ~8 min macos/x86_64 🍎dmg
✔️ 3e8fa0d #2 2024-02-19 10:34:38 ~11 min tests/ui 📄log
✔️ 3e8fa0d #2 2024-02-19 10:36:54 ~13 min linux/x86_64 📦tgz
✔️ 3e8fa0d #2 2024-02-19 10:44:26 ~20 min windows/x86_64 💿exe
✔️ 816214a #3 2024-02-19 12:53:48 ~5 min macos/aarch64 🍎dmg
✔️ 816214a #3 2024-02-19 12:54:40 ~6 min tests/nim 📄log
✔️ 816214a #3 2024-02-19 12:56:31 ~8 min macos/x86_64 🍎dmg
✔️ 816214a #3 2024-02-19 12:58:44 ~10 min tests/ui 📄log
✔️ 816214a #3 2024-02-19 13:03:31 ~15 min linux/x86_64 📦tgz
✔️ 816214a #3 2024-02-19 13:06:50 ~18 min windows/x86_64 💿exe

@caybro caybro force-pushed the 13520-profile-flow-mark-as-untrusted branch from 57d8b13 to 3e8fa0d Compare February 19, 2024 10:23
@caybro caybro marked this pull request as ready for review February 19, 2024 10:23
Copy link
Contributor

@alexandraB99 alexandraB99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

- add new popup for marking a person as untrusted
- optionally display checkboxes to remove ID verification or the contact
- emit toasts

Fixes #13520
@caybro caybro force-pushed the 13520-profile-flow-mark-as-untrusted branch from 3e8fa0d to 816214a Compare February 19, 2024 12:48
Copy link
Contributor

@MishkaRogachev MishkaRogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caybro caybro merged commit 4a3eb4c into master Feb 19, 2024
8 checks passed
@caybro caybro deleted the 13520-profile-flow-mark-as-untrusted branch February 19, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Profile flow] Mark as untrusted
4 participants