feat[StatusButton] missing green/success state #13624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
alexandraB99
approved these changes
Feb 19, 2024
- implemented the missing `StatusBaseButton.Type.Success` state and colors for both `StatusButton` and `StatusFlatButton` - use a `switch` instead of a waterfall of ternaries - adjust storybook for the new case Fixed #13622
caybro
force-pushed
the
13622-statusbutton-missing-greensuccess-state
branch
from
b30473a
to
0e602db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
StatusBaseButton.Type.Successstate and colors for bothStatusButtonandStatusFlatButtonswitchinstead of a waterfall of ternariesFixes #13622
Affected areas
Status[Base,Flat]Button
Screenshot of functionality (including design for comparison)
Zaznam.obrazovky.z.2024-02-19.14-36-28.webm