Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send modal community tokens always grouped and listview sections changed #13639

Conversation

IvanBelyakoff
Copy link
Contributor

@IvanBelyakoff IvanBelyakoff commented Feb 20, 2024

Closes #13430

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it
Screen.Recording.2024-02-26.at.11.31.15.mov

Screenshot of "Community minted" section in ERC20 tokens listview:
Screenshot 2024-02-21 at 14 58 34

@status-im-auto
Copy link
Member

status-im-auto commented Feb 20, 2024

Jenkins Builds

Click to see older builds (24)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b79e3c4 #1 2024-02-20 13:12:49 ~6 min tests/nim 📄log
✔️ b79e3c4 #1 2024-02-20 13:12:57 ~6 min macos/aarch64 🍎dmg
✔️ b79e3c4 #1 2024-02-20 13:15:52 ~9 min macos/x86_64 🍎dmg
✔️ b79e3c4 #1 2024-02-20 13:16:32 ~10 min tests/ui 📄log
✔️ b79e3c4 #1 2024-02-20 13:21:26 ~15 min linux/x86_64 📦tgz
✔️ b79e3c4 #1 2024-02-20 13:31:35 ~25 min windows/x86_64 💿exe
✔️ 2231df8 #2 2024-02-21 11:04:04 ~6 min tests/nim 📄log
✔️ 2231df8 #2 2024-02-21 11:06:26 ~8 min macos/aarch64 🍎dmg
✔️ 2231df8 #2 2024-02-21 11:08:13 ~10 min macos/x86_64 🍎dmg
✔️ 2231df8 #2 2024-02-21 11:08:24 ~10 min tests/ui 📄log
✔️ 2231df8 #2 2024-02-21 11:13:11 ~15 min linux/x86_64 📦tgz
✔️ 2231df8 #2 2024-02-21 11:18:23 ~20 min windows/x86_64 💿exe
✔️ 075373d #4 2024-02-21 14:00:12 ~6 min tests/nim 📄log
✔️ 075373d #4 2024-02-21 14:00:30 ~7 min macos/aarch64 🍎dmg
✔️ 075373d #4 2024-02-21 14:03:00 ~9 min macos/x86_64 🍎dmg
✔️ 075373d #4 2024-02-21 14:03:34 ~10 min tests/ui 📄log
✔️ 075373d #4 2024-02-21 14:09:43 ~16 min linux/x86_64 📦tgz
✔️ 075373d #4 2024-02-21 14:18:02 ~24 min windows/x86_64 💿exe
✔️ 13cefd5 #5 2024-02-26 09:55:54 ~5 min macos/aarch64 🍎dmg
✔️ 13cefd5 #5 2024-02-26 09:56:47 ~6 min tests/nim 📄log
✔️ 13cefd5 #5 2024-02-26 09:58:40 ~8 min macos/x86_64 🍎dmg
✔️ 13cefd5 #5 2024-02-26 10:01:09 ~10 min tests/ui 📄log
✔️ 13cefd5 #5 2024-02-26 10:06:19 ~15 min linux/x86_64 📦tgz
✔️ 13cefd5 #5 2024-02-26 10:13:40 ~23 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b7b127a #6 2024-02-26 10:20:39 ~4 min macos/aarch64 🍎dmg
✔️ b7b127a #6 2024-02-26 10:23:10 ~7 min tests/nim 📄log
✔️ b7b127a #6 2024-02-26 10:23:24 ~7 min macos/x86_64 🍎dmg
✔️ b7b127a #6 2024-02-26 10:26:40 ~10 min tests/ui 📄log
✔️ b7b127a #6 2024-02-26 10:33:05 ~17 min linux/x86_64 📦tgz
✔️ b7b127a #6 2024-02-26 10:38:00 ~21 min windows/x86_64 💿exe
✔️ 5596205 #7 2024-02-26 15:39:24 ~4 min macos/aarch64 🍎dmg
✔️ 5596205 #7 2024-02-26 15:41:37 ~6 min tests/nim 📄log
✔️ 5596205 #7 2024-02-26 15:42:26 ~7 min macos/x86_64 🍎dmg
✔️ 5596205 #7 2024-02-26 15:45:41 ~11 min tests/ui 📄log
✔️ 5596205 #7 2024-02-26 15:49:05 ~14 min linux/x86_64 📦tgz
✔️ 5596205 #7 2024-02-26 15:56:31 ~21 min windows/x86_64 💿exe

@IvanBelyakoff IvanBelyakoff force-pushed the feat/sendmodal_fix_section_names_group_commu_collectibles branch 3 times, most recently from d265633 to 075373d Compare February 21, 2024 13:53
Copy link
Contributor

@Khushboo-dev-cpp Khushboo-dev-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

vendor/status-go Outdated Show resolved Hide resolved
@IvanBelyakoff IvanBelyakoff force-pushed the feat/sendmodal_fix_section_names_group_commu_collectibles branch 2 times, most recently from 13cefd5 to b7b127a Compare February 26, 2024 10:15
@IvanBelyakoff IvanBelyakoff force-pushed the feat/sendmodal_fix_section_names_group_commu_collectibles branch from b7b127a to 5596205 Compare February 26, 2024 15:34
@IvanBelyakoff IvanBelyakoff merged commit be218c2 into master Feb 26, 2024
8 checks passed
@IvanBelyakoff IvanBelyakoff deleted the feat/sendmodal_fix_section_names_group_commu_collectibles branch February 26, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send flows updated to include "Community minted" and "Other" segmentation for collectibles list
4 participants