Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Profile flow): Remove a contact #13649

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

caybro
Copy link
Member

@caybro caybro commented Feb 20, 2024

What does the PR do

  • implement the new remove contact confirmation popup

Fixes #13521

Affected areas

RemoveContactPopup

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

Coming from ProfileDialog:
image

Chat context menu:
image

- implement the new remove contact confirmation popup

Fixes #13521
@caybro caybro linked an issue Feb 20, 2024 that may be closed by this pull request
@status-im-auto
Copy link
Member

status-im-auto commented Feb 20, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ad44401 #1 2024-02-20 17:30:06 ~6 min tests/nim 📄log
✔️ ad44401 #1 2024-02-20 17:30:29 ~6 min macos/aarch64 🍎dmg
✔️ ad44401 #1 2024-02-20 17:34:02 ~10 min tests/ui 📄log
✔️ ad44401 #1 2024-02-20 17:34:09 ~10 min macos/x86_64 🍎dmg
✔️ ad44401 #1 2024-02-20 17:40:28 ~16 min linux/x86_64 📦tgz
✔️ ad44401 #1 2024-02-20 17:55:06 ~31 min windows/x86_64 💿exe

Copy link
Contributor

@MishkaRogachev MishkaRogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@caybro caybro merged commit e46f6c3 into master Feb 20, 2024
8 checks passed
@caybro caybro deleted the 13521-profile-flow-remove-a-contact branch February 20, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Profile flow] Remove a contact
4 participants