Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@desktop/community): allow owner delete all messages during the ban and ban/unban AC notifications #13653

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

mprakhov
Copy link
Contributor

@mprakhov mprakhov commented Feb 20, 2024

What does the PR do

  • extend the Ban/Unban popup with the "Delete all messages" option
  • delete all messages during the ban functionality
  • AC notification for ban/unban
  • refactor names for functionality to split messages remove and delete
  • fixed bug when kicking user results to "Pending request" state

status-go PR: status-im/status-go#4743

Closes:

Affected areas

  • Messages deletion
  • AC notifications

Screenshot of functionality (including design for comparison)

Screen.Recording.2024-02-20.at.18.32.10.mov

@status-im-auto
Copy link
Member

status-im-auto commented Feb 20, 2024

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 22b2237 #1 2024-02-20 18:20:47 ~6 min tests/nim 📄log
✔️ 22b2237 #1 2024-02-20 18:24:49 ~10 min macos/x86_64 🍎dmg
✔️ 22b2237 #1 2024-02-20 18:25:37 ~10 min tests/ui 📄log
✔️ 22b2237 #1 2024-02-20 18:31:15 ~16 min linux/x86_64 📦tgz
✔️ 22b2237 #1 2024-02-20 18:50:40 ~35 min windows/x86_64 💿exe
✔️ 22b2237 #2 2024-02-20 19:18:56 ~7 min macos/aarch64 🍎dmg
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 57d8cd0 #3 2024-02-22 10:32:32 ~4 min macos/aarch64 🍎dmg
✔️ 73a5bb7 #4 2024-02-22 10:38:23 ~4 min macos/aarch64 🍎dmg
✔️ 73a5bb7 #3 2024-02-22 10:40:16 ~6 min tests/nim 📄log
✔️ 73a5bb7 #3 2024-02-22 10:44:22 ~10 min macos/x86_64 🍎dmg
✔️ 73a5bb7 #3 2024-02-22 10:44:29 ~10 min tests/ui 📄log
✔️ 73a5bb7 #3 2024-02-22 10:49:19 ~15 min linux/x86_64 📦tgz
✔️ 73a5bb7 #3 2024-02-22 10:59:32 ~25 min windows/x86_64 💿exe

Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@MishkaRogachev MishkaRogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mprakhov mprakhov merged commit 12569d7 into master Feb 22, 2024
8 checks passed
@mprakhov mprakhov deleted the mp/issue-13608 branch February 22, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants