Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Profile flow): Block/unblock user #13655

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

caybro
Copy link
Member

@caybro caybro commented Feb 20, 2024

What does the PR do

  • implement block and unblock user popups with optional "Remove contact" and "Remove ID verification" check boxes
  • emit (combined) toasts
  • separate commit to expose text size from StatusWarningBox

Fixes #13522

Affected areas

[Un]BlockConfirmationDialog

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

Block:
image

@caybro caybro linked an issue Feb 20, 2024 that may be closed by this pull request
@caybro caybro changed the title [Profile flow] Block/unblock user feat(Profile flow): Block/unblock user Feb 20, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Feb 20, 2024

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3a5b016 #1 2024-02-20 18:30:27 ~6 min tests/nim 📄log
✔️ 3a5b016 #1 2024-02-20 18:30:31 ~6 min macos/aarch64 🍎dmg
✔️ 3a5b016 #1 2024-02-20 18:33:59 ~9 min macos/x86_64 🍎dmg
3a5b016 #1 2024-02-20 18:35:15 ~10 min tests/ui 📄log
✔️ 3a5b016 #1 2024-02-20 18:40:26 ~16 min linux/x86_64 📦tgz
✔️ 8daa55b #2 2024-02-20 18:56:46 ~4 min macos/aarch64 🍎dmg
✔️ 8daa55b #2 2024-02-20 18:59:01 ~6 min tests/nim 📄log
✔️ 8daa55b #2 2024-02-20 19:01:20 ~8 min macos/x86_64 🍎dmg
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2deae10 #7 2024-02-20 19:19:50 ~6 min tests/nim 📄log
✔️ 2deae10 #7 2024-02-20 19:21:16 ~7 min macos/aarch64 🍎dmg
✔️ 2deae10 #7 2024-02-20 19:21:24 ~7 min macos/x86_64 🍎dmg
✔️ 2deae10 #7 2024-02-20 19:23:47 ~9 min tests/ui 📄log
✔️ 2deae10 #7 2024-02-20 19:27:32 ~13 min linux/x86_64 📦tgz
✔️ 2deae10 #7 2024-02-20 19:44:22 ~30 min windows/x86_64 💿exe
✔️ c7c6f85 #8 2024-02-21 18:10:16 ~6 min tests/nim 📄log
✔️ c7c6f85 #8 2024-02-21 18:11:15 ~7 min macos/aarch64 🍎dmg
✔️ c7c6f85 #8 2024-02-21 18:12:11 ~7 min macos/x86_64 🍎dmg
✔️ c7c6f85 #8 2024-02-21 18:14:25 ~10 min tests/ui 📄log
✔️ c7c6f85 #8 2024-02-21 18:18:57 ~14 min linux/x86_64 📦tgz
✔️ c7c6f85 #8 2024-02-21 18:29:36 ~25 min windows/x86_64 💿exe

@caybro caybro force-pushed the 13522-block-unblock-user branch 5 times, most recently from a60b8d4 to af72ecd Compare February 20, 2024 19:08
Copy link
Member

@micieslak micieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Some minor sizing issues found:

Screenshot from 2024-02-21 18-13-31

It would be nice to have all those popups in Storybook. E.g. sizing and other checks would be much easier then.

@caybro
Copy link
Member Author

caybro commented Feb 21, 2024

LGTM in general. Some minor sizing issues found:

It would be nice to have all those popups in Storybook. E.g. sizing and other checks would be much easier then.

Yup, you can access all of them from StoryBook via the ProfileDialogViewPage.

As for the sizing issues, one is a discrepancy inside StatusDialog's header, the other one with the warning box bottom margin I'll fix :)

- implement block and unblock user popups with optional "Remove contact" and "Remove ID verification" check boxes
- emit (combined) toasts

Fixes #13522
@caybro
Copy link
Member Author

caybro commented Feb 21, 2024

LGTM in general. Some minor sizing issues found:

It would be nice to have all those popups in Storybook. E.g. sizing and other checks would be much easier then.

@micieslak fixed:
image

@caybro caybro merged commit 343cfa0 into master Feb 21, 2024
8 checks passed
@caybro caybro deleted the 13522-block-unblock-user branch February 21, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Profile flow] Block/unblock user
4 participants