Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ProfileShowcase): Enable add more accounts component #13664

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

noeliaSD
Copy link
Contributor

Closes #13590

What does the PR do

  • Added new additional footer component in EmptyShapeRectangleFooterListView.
  • Enabled more accounts component in profile showcase assets and collectibles panel.

Affected areas

Profile showcase assets and collectibles tabs

Screenshot of functionality

Screen.Recording.2024-02-21.at.15.50.30.mov

- Added new additional footer component in `EmptyShapeRectangleFooterListView`.
- Enabled more accounts component in profile showcase assets and collectibles panel.

Closes #13590
@status-im-auto
Copy link
Member

status-im-auto commented Feb 21, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fffa786 #1 2024-02-21 14:59:53 ~6 min tests/nim 📄log
✔️ fffa786 #1 2024-02-21 14:59:54 ~6 min macos/aarch64 🍎dmg
✔️ fffa786 #1 2024-02-21 15:04:05 ~10 min macos/x86_64 🍎dmg
✔️ fffa786 #1 2024-02-21 15:04:39 ~10 min tests/ui 📄log
✔️ fffa786 #1 2024-02-21 15:10:07 ~16 min linux/x86_64 📦tgz
✔️ fffa786 #1 2024-02-21 15:28:08 ~34 min windows/x86_64 💿exe

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@noeliaSD noeliaSD merged commit f31f01d into master Feb 22, 2024
8 checks passed
@noeliaSD noeliaSD deleted the feat/issue-13590 branch February 22, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Profile Showcase] Add additional component in bottom of assets and collectibles profile showcase panels
4 participants