feat(@desktop/wallet): Update token details view #13667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
Khushboo-dev-cpp
force-pushed
the
fix/issue#12373
branch
from
ee2660c
to
6e6bd47
Compare
Khushboo-dev-cpp
requested review from
Cuteivist,
saledjenic,
caybro and
alaibe
caybro
approved these changes
Feb 23, 2024
| @@ -171,7 +171,7 @@ StatusScrollView { | |||
| regexValidator.regularExpression: Constants.regularExpressions.ascii | |||
| regexValidator.errorMessage: qsTr("Only A-Z, 0-9 and standard punctuation allowed") | |||
|
|
|||
| onTextChanged: root.token.description | |||
| onTextChanged: root.token.description = text | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12373
What does the PR do
Design implemented in this PR: https://www.figma.com/file/FkFClTCYKf83RJWoifWgoX/Wallet-v2?type=design&node-id=21330-199931&mode=design&t=CjaU66KwWS3bRgrp-4
Affected areas
AssetDetailsView
StatusQ checklist
Screenshot of functionality (including design for comparison)
Community Token:
Screen.Recording.2024-02-21.at.6.44.51.PM.mov
ERC20
ethDetails.mov