[ProfileSettings]: Added biometrics in password change view #13669
Conversation
Jenkins BuildsClick to see older builds (24)
|
|
|
||
| readonly property bool biometricsEnabled: localAccountSettings.storeToKeychainValue === Constants.keychain.storedValue.store | ||
| onBiometricsEnabledChanged: { | ||
| biometricsSwitch.checked = Qt.binding(() => { return root.biometricsEnabled }); |
There was a problem hiding this comment.
The biometricsSwitch is in a loader. On the first event the biometricsSwitch may not exist. An undefined check would be useful here.
There was a problem hiding this comment.
this will change only when the switch is checked/unchecked and the biometrics are enabled/disabled. so it should be good?
There was a problem hiding this comment.
there is a warning when this component gets loaded that the biometricsSwitch is undefined. We could remove it this way.
There was a problem hiding this comment.
@alexjba I don't see any warning but I've added the check anyways. in regards to the buttons cut, I can't see that one either
| } | ||
| StatusModal { | ||
| id: enableBiometricsPopup | ||
| title: biometricsSwitch.checked ? qsTr("Disable biometrics") : qsTr("Enable biometrics") |
There was a problem hiding this comment.
I'd link it to the root.biometricsEnabled as it's supposed to be the single source of truth for this feature. Looks like the biometricsSwitch.checked can have intermediary states. Just to make sure we don't have false positive/negative here.
Same below
There was a problem hiding this comment.
yeah, however at this stage, we have not yet enabled or disabled biometrics, so localAccountSettings.storeToKeychainValue hasn't changed yet
| StatusButton { | ||
| text: biometricsSwitch.checked ? qsTr("Yes, enable biometrics") : qsTr("Yes, disable biometrics") | ||
| onClicked: { | ||
| if (biometricsSwitch.checked && !biometricsSwitch.biometricsEnabled) { |
There was a problem hiding this comment.
| if (biometricsSwitch.checked && !biometricsSwitch.biometricsEnabled) { | |
| if (biometricsSwitch.checked && !root.biometricsEnabled) { |
I cannot reproduce this one, any specific steps? |
Try restarting the app and opening this popup once. It's happening only on the first open |
alexandraB99
force-pushed
the
feat/issue-13302
branch
from
ead13a2
to
314f26f
Compare
not sure how to react on the password's popup closing signal. |
still can't see it |
alexandraB99
force-pushed
the
feat/issue-13302
branch
3 times, most recently
from
736918b
to
1f0a796
Compare
alexandraB99
force-pushed
the
feat/issue-13302
branch
from
1f0a796
to
b0a3909
Compare
Closes #13302
What does the PR do
ProfileSettings: Added biometrics in password change view
Affected areas
ProfileSettings password change view
Screenshot of functionality (including design for comparison)
ff.mov