fix(async_tasks): add try catch to getChannelGroups async task #13673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kind of fixes #13640 The issue itself was no reproducible even after dozens of restarts and following of the repro steps. It seems like this was an unfortunate DB close event that caused the app to close. Adding a try catch won't actually fix that, since the DB is closed and also the `communtiies`already had a try/catch, but it will help for later.
Jenkins Builds
|
osmaczko
approved these changes
Feb 22, 2024
Yeah, I checked that issue yesterday to confirm that the channelGroup function was listed there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of fixes #13640
The issue itself was no reproducible even after dozens of restarts and following of the repro steps. It seems like this was an unfortunate DB close event that caused the app to close.
Adding a try catch won't actually fix that, since the DB is closed and also the
communtiiesalready had a try/catch, but it will help for later.