(desktop/fix) Fix Owner token holder representation #13712
Conversation
kounkou
force-pushed
the
fix-owner-token-holder-represented-as-address
branch
from
687c146
to
5e148c5
Compare
Jenkins BuildsClick to see older builds (37)
|
kounkou
force-pushed
the
fix-owner-token-holder-represented-as-address
branch
3 times, most recently
from
bc6f319
to
39f6812
Compare
ui/app/AppLayouts/Communities/popups/TokenMasterActionPopup.qml
Outdated
Show resolved
Hide resolved
kounkou
force-pushed
the
fix-owner-token-holder-represented-as-address
branch
4 times, most recently
from
453b4b7
to
b612c67
Compare
| sensor.enabled: false | ||
|
|
||
| Component.onCompleted: { | ||
| d.updateContactDetails(model.contactId) |
There was a problem hiding this comment.
Hmm, how does this work? You're fetching and overwriting the d.contactDetails for each delegate in the listview? 🤔 That sounds odd...
There was a problem hiding this comment.
I mean, doesn't the root.tokenOwnersModel already include it in some way? And if not, if should probably added to it, not fetched from the UI
There was a problem hiding this comment.
Thank you for taking the time to review, from the tokenOwnersModel, what could be extracted is the name and the contactId (cf. below. The other way to go about this would be to enrich the tokenOwnersModel with all the necessary details to be displayed and then fetch the information directly from the tokenOwners, not sure if this second approach seems overkill to me, wdyt?
Hmm, how does this work? You're fetching and overwriting the d.contactDetails for each delegate in the listview?
As of now, There is only 1 Owner token for a community so, the delegate is called once.
TokenOwnersItem* = object
contactId*: string
name*: string
imageSource*: string
numberOfMessages*: int
ownerDetails*: CollectibleOwner
amount*: Uint256
remotelyDestructState*: ContractTransactionStatus
There was a problem hiding this comment.
The solution would be to use the LeftJoinModel on the contactId
There was a problem hiding this comment.
The solution would be to use the LeftJoinModel on the contactId
Sure, I think that's the easy part though.
To accomplish what is asked by @caybro
I should pull the usersModel and Join it with he tokenOwnersModel on the contactId because it's better to use the Qt binding rather than fetching the contact details even if it's called only once here as of now (I suspect it might be called more than once later on reason why I used a list...). This is ideal solution for sure, it might take me a bit more time (probably 1 more day) than I had expected judging on the usage of the contact details. I'll be working on it now CC @jrainville
There was a problem hiding this comment.
So I have sent a new revision making use of a LeftJoinModel for extracting the ownerToken after crossing it with the members available to the CommunitySettingsView component. Please @caybro let me know what you think.
Not directly related to this ticket, trying to understand why I don't have update of the properties... After a quick look, it seems like the Members panel as well don't have updates on the members properties. This is most likely a bug. I can have a look in a different ticket. On this screenshot the Phoenix-2 is offline in the Members list but online in the bottom left corner
kounkou
force-pushed
the
fix-owner-token-holder-represented-as-address
branch
3 times, most recently
from
69f5c6e
to
8e04f60
Compare
kounkou
force-pushed
the
fix-owner-token-holder-represented-as-address
branch
from
8e04f60
to
fc9b500
Compare
src/app/modules/main/communities/tokens/models/token_owners_item.nim
Outdated
Show resolved
Hide resolved
kounkou
force-pushed
the
fix-owner-token-holder-represented-as-address
branch
from
fc9b500
to
01d7034
Compare
|
@kounkou please rebase to let the tests pass |
fix #12065 token owner presentation in Token section by displaying the owner token holder as contact
kounkou
force-pushed
the
fix-owner-token-holder-represented-as-address
branch
from
01d7034
to
597af88
Compare
Description
Fix #12065 token owner presentation in Token section by displaying the owner token holder as contact
What does the PR do
Fetch the contactDetails for the token owner found in the tokenOwnerModel.
Affected areas
MintedTokenView page
Screenshot of functionality (including design for comparison)
Figma:
The following match the UI expectations