-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/12311 collectible details activity tab #13714
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlipicar
changed the base branch from
master
to
fix/13660-fix-activity-filter-tokenid-zero
February 26, 2024 02:38
Jenkins BuildsClick to see older builds (11)
|
Base automatically changed from
fix/13660-fix-activity-filter-tokenid-zero
to
master
February 26, 2024 10:55
dlipicar
force-pushed
the
feat/12311-collectible-details-activity-tab
branch
from
February 26, 2024 12:10
50e5955
to
1fe86a1
Compare
alaibe
approved these changes
Feb 28, 2024
ui/app/AppLayouts/Wallet/views/collectibles/CollectibleDetailView.qml
Outdated
Show resolved
Hide resolved
ui/app/AppLayouts/Wallet/views/collectibles/CollectibleDetailView.qml
Outdated
Show resolved
Hide resolved
IvanBelyakoff
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dlipicar
force-pushed
the
feat/12311-collectible-details-activity-tab
branch
from
February 28, 2024 15:36
1fe86a1
to
85a93f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes ##12311
Implements the Collectible Details Activity tab.
Switching to the Transaction Details screen on click is left for a separate PR (#13721), since it involves a bit of rework of how it's currently handled in the HistoryView component.