Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/12311 collectible details activity tab #13714

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

dlipicar
Copy link
Contributor

@dlipicar dlipicar commented Feb 26, 2024

What does the PR do

Fixes ##12311

Implements the Collectible Details Activity tab.

Switching to the Transaction Details screen on click is left for a separate PR (#13721), since it involves a bit of rework of how it's currently handled in the HistoryView component.

image

image

@dlipicar dlipicar changed the base branch from master to fix/13660-fix-activity-filter-tokenid-zero February 26, 2024 02:38
@status-im-auto
Copy link
Member

status-im-auto commented Feb 26, 2024

Jenkins Builds

Click to see older builds (11)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 50e5955 #2 2024-02-26 02:44:04 ~5 min tests/nim 📄log
✔️ 50e5955 #2 2024-02-26 02:45:48 ~7 min macos/aarch64 🍎dmg
✔️ 50e5955 #2 2024-02-26 02:48:25 ~10 min tests/ui 📄log
✔️ 50e5955 #2 2024-02-26 02:49:25 ~11 min macos/x86_64 🍎dmg
✔️ 50e5955 #2 2024-02-26 03:02:52 ~24 min windows/x86_64 💿exe
✔️ 50e5955 #3 2024-02-26 11:02:23 ~6 min tests/nim 📄log
✔️ 50e5955 #3 2024-02-26 11:02:24 ~6 min macos/aarch64 🍎dmg
✔️ 50e5955 #3 2024-02-26 11:03:04 ~7 min macos/x86_64 🍎dmg
✔️ 50e5955 #3 2024-02-26 11:06:05 ~10 min tests/ui 📄log
✔️ 50e5955 #4 2024-02-26 11:12:59 ~17 min linux/x86_64 📦tgz
✔️ 50e5955 #3 2024-02-26 11:15:14 ~19 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1fe86a1 #4 2024-02-26 12:15:27 ~4 min macos/aarch64 🍎dmg
✔️ 1fe86a1 #4 2024-02-26 12:16:31 ~5 min tests/nim 📄log
✔️ 1fe86a1 #4 2024-02-26 12:18:44 ~8 min macos/x86_64 🍎dmg
✔️ 1fe86a1 #4 2024-02-26 12:20:46 ~10 min tests/ui 📄log
✔️ 1fe86a1 #4 2024-02-26 12:31:06 ~20 min windows/x86_64 💿exe
✔️ 1fe86a1 #6 2024-02-26 19:56:51 ~15 min linux/x86_64 📦tgz
✔️ 85a93f5 #5 2024-02-28 15:41:16 ~4 min macos/aarch64 🍎dmg
✔️ 85a93f5 #5 2024-02-28 15:43:22 ~6 min tests/nim 📄log
✔️ 85a93f5 #5 2024-02-28 15:44:39 ~8 min macos/x86_64 🍎dmg
✔️ 85a93f5 #5 2024-02-28 15:48:23 ~11 min tests/ui 📄log
✔️ 85a93f5 #7 2024-02-28 15:52:59 ~16 min linux/x86_64 📦tgz
✔️ 85a93f5 #5 2024-02-28 16:01:04 ~24 min windows/x86_64 💿exe

Base automatically changed from fix/13660-fix-activity-filter-tokenid-zero to master February 26, 2024 10:55
@dlipicar dlipicar force-pushed the feat/12311-collectible-details-activity-tab branch from 50e5955 to 1fe86a1 Compare February 26, 2024 12:10
Copy link
Contributor

@IvanBelyakoff IvanBelyakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlipicar dlipicar force-pushed the feat/12311-collectible-details-activity-tab branch from 1fe86a1 to 85a93f5 Compare February 28, 2024 15:36
@dlipicar dlipicar merged commit 10c44b8 into master Feb 28, 2024
8 checks passed
@dlipicar dlipicar deleted the feat/12311-collectible-details-activity-tab branch February 28, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants