Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Profile flow) Mark as ID verified / remove verification #13717

Merged

Conversation

caybro
Copy link
Member

@caybro caybro commented Feb 26, 2024

Note

This won't work directly in the app as of now, needs the appropriate backend: #13716

What does the PR do

  • implement two new actions and popups to directly mark a contact as "ID verified" and remove the verification thereof respectively
  • do not hardcode the secondary button inside ProfileDialogView and make it a Loader
  • make the CommonContactDialog contents scrollable

Fixes #13711

Affected areas

ProfileDialogView, ProfileContextMenu

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

Optional secondary button for a contact ("Request ID verification):
image

Mark as ID verified popup:
image

ID verified + action to remove:
image

Popup to remove the ID verified status (+ optionally mark as untrusted or remove the contact):
image

@status-im-auto
Copy link
Member

status-im-auto commented Feb 26, 2024

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f4a3eb8 #1 2024-02-26 09:55:56 ~6 min tests/nim 📄log
✔️ f4a3eb8 #1 2024-02-26 09:56:31 ~6 min macos/aarch64 🍎dmg
✔️ f4a3eb8 #1 2024-02-26 10:01:19 ~11 min tests/ui 📄log
✔️ f4a3eb8 #1 2024-02-26 10:01:55 ~12 min macos/x86_64 🍎dmg
✔️ f4a3eb8 #1 2024-02-26 10:06:33 ~16 min linux/x86_64 📦tgz
✔️ f4a3eb8 #1 2024-02-26 10:21:29 ~31 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f80d25c #2 2024-02-26 12:33:57 ~4 min macos/aarch64 🍎dmg
✔️ f80d25c #2 2024-02-26 12:35:48 ~6 min tests/nim 📄log
✔️ f80d25c #2 2024-02-26 12:37:13 ~7 min macos/x86_64 🍎dmg
✔️ f80d25c #2 2024-02-26 12:40:31 ~11 min tests/ui 📄log
✔️ f80d25c #2 2024-02-26 12:43:16 ~14 min linux/x86_64 📦tgz
✔️ f80d25c #2 2024-02-26 12:54:59 ~25 min windows/x86_64 💿exe
✔️ 955f2e2 #3 2024-02-26 14:17:04 ~4 min macos/aarch64 🍎dmg
✔️ 955f2e2 #3 2024-02-26 14:19:33 ~6 min tests/nim 📄log
✔️ 955f2e2 #3 2024-02-26 14:20:25 ~7 min macos/x86_64 🍎dmg
✔️ 955f2e2 #3 2024-02-26 14:23:41 ~10 min tests/ui 📄log
✔️ 955f2e2 #3 2024-02-26 14:28:18 ~15 min linux/x86_64 📦tgz
✔️ 955f2e2 #3 2024-02-26 14:36:25 ~23 min windows/x86_64 💿exe

Copy link
Contributor

@MishkaRogachev MishkaRogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ui/app/mainui/Popups.qml Show resolved Hide resolved
@Valentina1133
Copy link
Contributor

I checked test run for this PR and also checked it manually on build from this PR.

Nothing happens if I click Back up Seed phrase in Settings, buttons Create or Import community, also Setup syncing.

https://ci.status.im/job/status-desktop/job/e2e/job/prs/1769/allure/#suites/804b25da7c0d1c4c7f8a050c6a89e043/8141b1a26bb644d3/

I also runned all tests - waiting for results now, but it seems there are more buttons with the same behaviour. Checked master build - there is no issue with these buttons

@caybro caybro force-pushed the 13711-profile-flow-mark-as-id-verified-remove-verification branch from f4a3eb8 to f80d25c Compare February 26, 2024 12:29
@caybro
Copy link
Member Author

caybro commented Feb 26, 2024

I checked test run for this PR and also checked it manually on build from this PR.

Nothing happens if I click Back up Seed phrase in Settings, buttons Create or Import community, also Setup syncing.

https://ci.status.im/job/status-desktop/job/e2e/job/prs/1769/allure/#suites/804b25da7c0d1c4c7f8a050c6a89e043/8141b1a26bb644d3/

I also runned all tests - waiting for results now, but it seems there are more buttons with the same behaviour. Checked master build - there is no issue with these buttons

I haven't touched any of that... seems like this is coming from master

- implement two new actions and popups to directly mark a contact as "ID
verified" and remove the verification thereof respectively
- do not hardcode the secondary button inside ProfileDialogView and make
it a Loader
- make the CommonContactDialog contents scrollable

Fixes #13711
@caybro caybro force-pushed the 13711-profile-flow-mark-as-id-verified-remove-verification branch from f80d25c to 955f2e2 Compare February 26, 2024 14:12
@anastasiyaig
Copy link
Contributor

I checked test run for this PR and also checked it manually on build from this PR.

Nothing happens if I click Back up Seed phrase in Settings, buttons Create or Import community, also Setup syncing.

https://ci.status.im/job/status-desktop/job/e2e/job/prs/1769/allure/#suites/804b25da7c0d1c4c7f8a050c6a89e043/8141b1a26bb644d3/

I also runned all tests - waiting for results now, but it seems there are more buttons with the same behaviour. Checked master build - there is no issue with these buttons

we figured it out @Valentina1133 , there were some needed changes missing in this commit so tests were failing on purpose. All good now

@caybro caybro merged commit 4d3745d into master Feb 26, 2024
8 checks passed
@caybro caybro deleted the 13711-profile-flow-mark-as-id-verified-remove-verification branch February 26, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Profile flow] Mark as ID verified / remove verification
6 participants