-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Profile flow) Mark as ID verified / remove verification #13717
feat(Profile flow) Mark as ID verified / remove verification #13717
Conversation
Jenkins BuildsClick to see older builds (6)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I checked test run for this PR and also checked it manually on build from this PR. Nothing happens if I click Back up Seed phrase in Settings, buttons Create or Import community, also Setup syncing. I also runned all tests - waiting for results now, but it seems there are more buttons with the same behaviour. Checked master build - there is no issue with these buttons |
f4a3eb8
to
f80d25c
Compare
I haven't touched any of that... seems like this is coming from master |
- implement two new actions and popups to directly mark a contact as "ID verified" and remove the verification thereof respectively - do not hardcode the secondary button inside ProfileDialogView and make it a Loader - make the CommonContactDialog contents scrollable Fixes #13711
f80d25c
to
955f2e2
Compare
we figured it out @Valentina1133 , there were some needed changes missing in this commit so tests were failing on purpose. All good now |
Note
This won't work directly in the app as of now, needs the appropriate backend: #13716
What does the PR do
Fixes #13711
Affected areas
ProfileDialogView, ProfileContextMenu
Screenshot of functionality (including design for comparison)
Optional secondary button for a contact ("Request ID verification):
Mark as ID verified popup:
ID verified + action to remove:
Popup to remove the ID verified status (+ optionally mark as untrusted or remove the contact):