feat(ProfileShowcase): Adds drop area in collapsed headers #13722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It adds an additional right component to `FoldableHeader.qml`. - It adds hidden button component in `hidden` foldable header. - It adds visibility buttons component in `in showcase` foldable header. Closes #13595
Jenkins Builds
|
alexjba
reviewed
Feb 27, 2024
There was a problem hiding this comment.
Code LGTM!
There's a strange behaviour though:
When dropping a hidden item into in showcase header, the view is automatically scrolled up and it can't be scrolled down from within the double flickable.
Have a look at this for a better understanding:
Screen.Recording.2024-02-27.at.11.59.49.mov
I think this is bc of the save changes popup that should appear on bottom and moves everything a bit on top.. we should fix that issue with this task: #13517 |
alexjba
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13595
What does the PR do
FoldableHeader.qml.hiddenfoldable header.in showcasefoldable header.NOTE / Known issues: App can behave wrongly until #13498 is integrated. Right now changing visibility of items trigger some unnecessary model resets that can cause UI misbehaviors (i.e: collapsing / uncollapsing section items).
Affected areas
Profile showcase communities, accounts, assets and collectibles tabs.
Screenshot of functionality
Screen.Recording.2024-02-26.at.13.33.50.mov