feat(Profile flow) ID verification flows (incoming/outgoing) #13727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
force-pushed
the
13709-profile-flow-id-verification-flows-incomingoutgoing
branch
from
4925b0f
to
401a10c
Compare
Jenkins BuildsClick to see older builds (44)
|
caybro
force-pushed
the
13709-profile-flow-id-verification-flows-incomingoutgoing
branch
6 times, most recently
from
2440bfb
to
a52c89b
Compare
caybro
requested review from
MishkaRogachev,
igor-sirotin,
alexandraB99 and
alexjba
caybro
force-pushed
the
13709-profile-flow-id-verification-flows-incomingoutgoing
branch
2 times, most recently
from
0be8ad4
to
8160a4c
Compare
MishkaRogachev
approved these changes
Feb 29, 2024
| @@ -58,7 +54,7 @@ CommonContactDialog { | |||
|
|
|||
| StatusCheckBox { | |||
| id: ctrlRemoveIDVerification | |||
| visible: contactDetails.isContact && !d.isTrusted && d.isVerificationRequestReceived | |||
| visible: (contactDetails.isContact && d.isTrusted) || contactDetails.trustStatus === Constants.trustStatus.trusted | |||
There was a problem hiding this comment.
imo contactDetails.isContact && d.isTrusted) is sufficient
There was a problem hiding this comment.
Yeah I wanted to make double sure (also for Storybook) :) It can't hurt and also I wasn't certain how this would get implemented in the end when I started working on this
caybro
force-pushed
the
13709-profile-flow-id-verification-flows-incomingoutgoing
branch
from
8160a4c
to
01cc5e3
Compare
alexjba
approved these changes
Mar 4, 2024
| Component.onCompleted: { | ||
| Global.userProfile = { | ||
| name: "Anna", | ||
| pubKey: "Oxdeadbeef", |
caybro
deleted the
13709-profile-flow-id-verification-flows-incomingoutgoing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
verification flows
Fixes #13709
Fixes #13745
Fixes #13747
Affected areas
ProfileDialogView, ProfileContextMenu
Screenshot of functionality (including design for comparison)
Request/send an ID request:
Reply to incoming ID request:
View pending ID request/reply:
Accept/reject pending ID request:
