Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: object name for build showcase button added #13733

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Valentina1133
Copy link
Contributor

@Valentina1133 Valentina1133 commented Feb 27, 2024

What does the PR do

Object name for build showcase button added

Affected areas

ProfileShowcaseInfoPopup.qml

@Valentina1133 Valentina1133 changed the title chore: object name for build showcase button added and fixed small typo chore: object name for build showcase button added and small typo fixed Feb 27, 2024
@Valentina1133 Valentina1133 force-pushed the chore/object_name_for_build_showcase branch from 18e8e4d to bd697ba Compare February 27, 2024 07:24
@status-im-auto
Copy link
Member

status-im-auto commented Feb 27, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ bd697ba #2 2024-02-27 07:31:07 ~6 min tests/nim 📄log
✔️ bd697ba #2 2024-02-27 07:31:54 ~6 min macos/aarch64 🍎dmg
✔️ bd697ba #2 2024-02-27 07:35:23 ~10 min tests/ui 📄log
✔️ 8fa6c30 #3 2024-02-27 07:44:09 ~4 min macos/aarch64 🍎dmg
✔️ 8fa6c30 #3 2024-02-27 07:46:02 ~6 min tests/nim 📄log
✔️ 8fa6c30 #3 2024-02-27 07:48:47 ~9 min macos/x86_64 🍎dmg
✔️ 8fa6c30 #3 2024-02-27 07:50:45 ~10 min tests/ui 📄log
✔️ 8fa6c30 #3 2024-02-27 07:54:47 ~15 min linux/x86_64 📦tgz
✔️ 8fa6c30 #10 2024-02-27 13:08:39 ~34 min windows/x86_64 💿exe

@@ -44,7 +44,7 @@ StatusDialog {
background: Item {}
checkersModel: [
qsTr("Communities you are a member of"),
qsTr("Assets and collectibles you hodl"),
qsTr("Assets and collectibles you hold"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
qsTr("Assets and collectibles you hold"),
qsTr("Assets and collectibles you hodl"),

that is on purpose

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Really? Ok. Will remove this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Valentina1133 Valentina1133 force-pushed the chore/object_name_for_build_showcase branch from bd697ba to 8fa6c30 Compare February 27, 2024 07:39
@Valentina1133 Valentina1133 changed the title chore: object name for build showcase button added and small typo fixed chore: object name for build showcase button added Feb 27, 2024
@anastasiyaig anastasiyaig merged commit 6de7032 into master Feb 27, 2024
8 checks passed
@anastasiyaig anastasiyaig deleted the chore/object_name_for_build_showcase branch February 27, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants