feat(@wallet): unknown token #13737

alaibe · 2024-02-27T11:08:08Z

status-im-auto · 2024-02-27T11:15:07Z

Jenkins Builds

Click to see older builds (60)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`1a16dec`	#1	2024-02-27 11:15:07	~6 min	`tests/nim`	📄`log`
✔️	`1a16dec`	#1	2024-02-27 11:16:18	~7 min	`macos/aarch64`	🍎`dmg`
❌	`1a16dec`	#1	2024-02-27 11:18:57	~10 min	`tests/ui`	📄`log`
✔️	`1a16dec`	#1	2024-02-27 11:21:09	~12 min	`macos/x86_64`	🍎`dmg`
✔️	`1a16dec`	#1	2024-02-27 11:24:56	~16 min	`linux/x86_64`	📦`tgz`
✔️	`1a16dec`	#1	2024-02-27 11:41:21	~32 min	`windows/x86_64`	💿`exe`
❌	`1a16dec`	#2	2024-02-27 12:39:35	~7 min	`tests/ui`	📄`log`

✔️	`df6313f`	#2	2024-02-27 12:59:17	~6 min	`tests/nim`	📄`log`
✔️	`df6313f`	#2	2024-02-27 13:00:34	~7 min	`macos/aarch64`	🍎`dmg`
✔️	`df6313f`	#2	2024-02-27 13:01:01	~8 min	`macos/x86_64`	🍎`dmg`
❌	`df6313f`	#3	2024-02-27 13:02:55	~9 min	`tests/ui`	📄`log`
✔️	`df6313f`	#2	2024-02-27 13:08:23	~15 min	`linux/x86_64`	📦`tgz`
✔️	`df6313f`	#2	2024-02-27 13:18:26	~25 min	`windows/x86_64`	💿`exe`

✔️	`1fe8dbf`	#3	2024-02-27 13:38:40	~9 min	`tests/nim`	📄`log`
✔️	`1fe8dbf`	#3	2024-02-27 13:44:38	~15 min	`macos/aarch64`	🍎`dmg`
❌	`1fe8dbf`	#4	2024-02-27 13:44:56	~16 min	`tests/ui`	📄`log`
✔️	`1fe8dbf`	#3	2024-02-27 13:48:05	~19 min	`linux/x86_64`	📦`tgz`
✔️	`1fe8dbf`	#3	2024-02-27 13:55:26	~26 min	`windows/x86_64`	💿`exe`
✔️	`1fe8dbf`	#3	2024-02-27 14:45:16	~1 hr 16 min	`macos/x86_64`	🍎`dmg`

✔️	`1084f1e`	#4	2024-02-27 16:04:49	~24 min	`windows/x86_64`	💿`exe`
✔️	`1084f1e`	#5	2024-02-27 16:05:40	~25 min	`tests/ui`	📄`log`
✔️	`1084f1e`	#4	2024-02-27 16:05:45	~25 min	`tests/nim`	📄`log`
✔️	`1084f1e`	#4	2024-02-27 16:10:57	~31 min	`linux/x86_64`	📦`tgz`
✔️	`1084f1e`	#4	2024-02-27 16:47:32	~1 hr 7 min	`macos/aarch64`	🍎`dmg`
✔️	`1084f1e`	#4	2024-02-27 18:12:22	~2 hr 32 min	`macos/x86_64`	🍎`dmg`

✔️	`c143a9a`	#6	2024-02-28 08:05:05	~5 min	`tests/nim`	📄`log`
✔️	`c143a9a`	#6	2024-02-28 08:07:09	~7 min	`macos/aarch64`	🍎`dmg`
✔️	`c143a9a`	#6	2024-02-28 08:07:57	~7 min	`macos/x86_64`	🍎`dmg`
✔️	`c143a9a`	#7	2024-02-28 08:09:36	~9 min	`tests/ui`	📄`log`
✔️	`c143a9a`	#6	2024-02-28 08:16:48	~16 min	`linux/x86_64`	📦`tgz`
✔️	`c143a9a`	#6	2024-02-28 08:31:14	~31 min	`windows/x86_64`	💿`exe`

❌	`f256676`	#7	2024-02-29 09:58:51	~3 min	`windows/x86_64`	📄`log`
✔️	`f256676`	#7	2024-02-29 10:01:05	~5 min	`macos/aarch64`	🍎`dmg`
✔️	`f256676`	#7	2024-02-29 10:01:44	~6 min	`tests/nim`	📄`log`

❌	`2761574`	#8	2024-02-29 10:03:11	~55 sec	`windows/x86_64`	📄`log`
✔️	`2761574`	#8	2024-02-29 10:07:22	~5 min	`macos/aarch64`	🍎`dmg`
✔️	`2761574`	#8	2024-02-29 10:08:59	~6 min	`tests/nim`	📄`log`
✔️	`2761574`	#8	2024-02-29 10:10:14	~7 min	`macos/x86_64`	🍎`dmg`
❌	`2761574`	#9	2024-02-29 10:12:48	~1 min	`windows/x86_64`	📄`log`
❌	`2761574`	#9	2024-02-29 10:13:44	~11 min	`tests/ui`	📄`log`
✔️	`2761574`	#8	2024-02-29 10:16:59	~14 min	`linux/x86_64`	📦`tgz`

❌	`3f70082`	#10	2024-02-29 10:21:33	~1 min	`windows/x86_64`	📄`log`
✔️	`3f70082`	#9	2024-02-29 10:25:37	~5 min	`macos/aarch64`	🍎`dmg`
✔️	`3f70082`	#9	2024-02-29 10:27:20	~6 min	`tests/nim`	📄`log`
✔️	`3f70082`	#9	2024-02-29 10:27:26	~6 min	`macos/x86_64`	🍎`dmg`
❌	`3f70082`	#10	2024-02-29 10:31:21	~10 min	`tests/ui`	📄`log`
✔️	`3f70082`	#9	2024-02-29 10:35:41	~15 min	`linux/x86_64`	📦`tgz`

❌	`f33ab66`	#11	2024-02-29 10:55:51	~58 sec	`windows/x86_64`	📄`log`
✔️	`f33ab66`	#10	2024-02-29 11:00:41	~5 min	`macos/aarch64`	🍎`dmg`
✔️	`f33ab66`	#10	2024-02-29 11:00:43	~5 min	`tests/nim`	📄`log`
✔️	`f33ab66`	#10	2024-02-29 11:01:47	~6 min	`macos/x86_64`	🍎`dmg`
✔️	`f33ab66`	#11	2024-02-29 11:05:33	~10 min	`tests/ui`	📄`log`
✔️	`f33ab66`	#10	2024-02-29 11:10:33	~15 min	`linux/x86_64`	📦`tgz`
❌	`f33ab66`	#12	2024-02-29 11:23:01	~58 sec	`windows/x86_64`	📄`log`

❌	`a69460f`	#13	2024-02-29 14:29:51	~1 min	`windows/x86_64`	📄`log`
✔️	`a69460f`	#11	2024-02-29 14:33:02	~4 min	`macos/aarch64`	🍎`dmg`
✔️	`a69460f`	#11	2024-02-29 14:35:45	~7 min	`tests/nim`	📄`log`
✔️	`a69460f`	#11	2024-02-29 14:36:12	~7 min	`macos/x86_64`	🍎`dmg`
✔️	`a69460f`	#12	2024-02-29 14:39:24	~10 min	`tests/ui`	📄`log`
✔️	`a69460f`	#11	2024-02-29 14:44:25	~15 min	`linux/x86_64`	📦`tgz`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`26e300f`	#14	2024-03-01 09:31:08	~1 min	`windows/x86_64`	📄`log`
✔️	`26e300f`	#12	2024-03-01 09:35:23	~5 min	`macos/aarch64`	🍎`dmg`
✔️	`26e300f`	#12	2024-03-01 09:36:22	~6 min	`tests/nim`	📄`log`
✔️	`26e300f`	#12	2024-03-01 09:37:45	~7 min	`macos/x86_64`	🍎`dmg`
✔️	`26e300f`	#13	2024-03-01 09:40:58	~10 min	`tests/ui`	📄`log`
✔️	`26e300f`	#12	2024-03-01 09:45:23	~15 min	`linux/x86_64`	📦`tgz`
❌	`26e300f`	#15	2024-03-01 10:00:44	~56 sec	`windows/x86_64`	📄`log`
❌	`26e300f`	#16	2024-03-01 12:21:08	~54 sec	`windows/x86_64`	📄`log`
❌	`26e300f`	#17	2024-03-01 12:27:09	~53 sec	`windows/x86_64`	📄`log`
❌	`26e300f`	#18	2024-03-04 09:25:52	~1 min	`windows/x86_64`	📄`log`

❌	`c448239`	#19	2024-03-11 09:44:36	~57 sec	`windows/x86_64`	📄`log`
✔️	`c448239`	#13	2024-03-11 09:48:20	~4 min	`macos/aarch64`	🍎`dmg`
✔️	`c448239`	#13	2024-03-11 09:49:52	~6 min	`tests/nim`	📄`log`
✔️	`c448239`	#13	2024-03-11 09:52:27	~8 min	`macos/x86_64`	🍎`dmg`
✔️	`c448239`	#14	2024-03-11 09:55:43	~12 min	`tests/ui`	📄`log`
✔️	`c448239`	#13	2024-03-11 09:59:41	~16 min	`linux/x86_64`	📦`tgz`
✔️	`c448239`	#20	2024-03-11 10:28:59	~30 min	`windows/x86_64`	💿`exe`

ui/app/AppLayouts/Communities/views/CommunitySettingsView.qml

ui/app/AppLayouts/Wallet/controls/ManageTokensCommunityTag.qml

ui/app/AppLayouts/Wallet/controls/ManageTokensGroupDelegate.qml

ui/app/AppLayouts/Communities/panels/MintTokensSettingsPanel.qml

ui/app/AppLayouts/Communities/views/CommunitySettingsView.qml

ui/app/AppLayouts/Communities/views/MintedTokensView.qml

ui/app/AppLayouts/Profile/panels/ProfileShowcaseCollectiblesPanel.qml

ui/app/AppLayouts/Profile/views/wallet/ManageTokensView.qml

ui/app/AppLayouts/Wallet/controls/ManageTokensGroupDelegate.qml

ui/app/AppLayouts/Wallet/panels/ManageHiddenPanel.qml

ui/app/AppLayouts/Wallet/views/CollectiblesView.qml

noeliaSD

In general it LGTM. I've just added some comments.

It would be nice to add in storybook this new state when we don't have the info of the community. I.e: adding new entry in ManageCollectiblesModel. Here an example where I modified an existing entry setting the communityName field to empty:

Screen.Recording.2024-02-28.at.11.25.34.mov

Here I don't see the complete desired behaviour, it shows the ? tag but it doesn't show neither the tooltip nor the Unknow Community text. Probably it's bc my model entry change is not fully correct but it's worth it to look at it and see the expected behaviour also in storybook.

Then, I can see something strange here, so probably some corner case we are not taking into account:

And how this same item looks like on master:

ui/app/AppLayouts/Wallet/controls/ManageTokensCommunityTag.qml

alaibe · 2024-02-29T10:02:33Z

@noeliaSD in the storybook. this as it should be, the name of the community is actually what is being shown.
I augmented the data with the new usecase

anastasiyaig · 2024-02-29T18:35:12Z

@alaibe i can't change password in this build, the app crashes

DBG 2024-02-29 21:33:50.309+03:00 [threadpool task thread] initiating task   topics="task-threadpool" tid=29353731 file=threadpool.nim:54 messageType=ChangeDatabasePasswordTaskArg:ObjectType threadid=29353731 task="{\"$type\":\"ChangeDatabasePasswordTaskArg:ObjectType\",\"accountId\":\"0x6a14581203171b406ca6258fc3d74b877bca3b810a92a9efca51854700a8dd7e\",\"currentPassword\":\"0x24c0d7a066ff54818763e54d728333d390230a3748b813fa082f3bb07d0d4ef5\",\"newPassword\":\"0xa4ea805dd7b7e22b1f4f1a3d645e048d8bd4f0d98d913253f3d50cf4ab3631ce\",\"vptr\":105553160581184,\"slot\":\"onChangeDatabasePasswordResponse\",\"tptr\":4302545812}"
WRN 2024-02-29 21:33:52.725+03:00 Error decoding signal                      topics="signals-manager" tid=29353701 file=signals_manager.nim:49 err="Unknown signal received: mediaserver.started"
SIGSEGV: Illegal storage access. (Attempt to read from nil?)

perhaps something wrong with rebase?

caybro

LGTM

Modulo the comments from Noelia

noeliaSD

Thanks for the fixes!

alaibe force-pushed the feat/unknown-community branch 2 times, most recently from df6313f to 1fe8dbf Compare February 27, 2024 13:28

noeliaSD reviewed Feb 27, 2024

View reviewed changes

ui/app/AppLayouts/Communities/views/CommunitySettingsView.qml Outdated Show resolved Hide resolved

noeliaSD reviewed Feb 27, 2024

View reviewed changes

ui/app/AppLayouts/Wallet/controls/ManageTokensCommunityTag.qml Outdated Show resolved Hide resolved

noeliaSD reviewed Feb 27, 2024

View reviewed changes

ui/app/AppLayouts/Wallet/controls/ManageTokensGroupDelegate.qml Outdated Show resolved Hide resolved

alaibe force-pushed the feat/unknown-community branch 3 times, most recently from 29be787 to c143a9a Compare February 28, 2024 07:59

alaibe requested review from dlipicar, Khushboo-dev-cpp and noeliaSD February 28, 2024 08:01

alaibe marked this pull request as ready for review February 28, 2024 08:01

caybro self-requested a review February 28, 2024 09:45

caybro reviewed Feb 28, 2024

View reviewed changes

noeliaSD reviewed Feb 28, 2024

View reviewed changes

ui/app/AppLayouts/Wallet/controls/ManageTokensCommunityTag.qml Show resolved Hide resolved

ui/app/AppLayouts/Wallet/controls/ManageTokensCommunityTag.qml Outdated Show resolved Hide resolved

alaibe force-pushed the feat/unknown-community branch from c143a9a to f256676 Compare February 29, 2024 09:55

alaibe requested review from noeliaSD and caybro February 29, 2024 09:55

alaibe force-pushed the feat/unknown-community branch from f256676 to 2761574 Compare February 29, 2024 10:01

alaibe force-pushed the feat/unknown-community branch 3 times, most recently from f33ab66 to a69460f Compare February 29, 2024 14:28

caybro approved these changes Feb 29, 2024

View reviewed changes

alaibe force-pushed the feat/unknown-community branch from a69460f to 26e300f Compare March 1, 2024 09:29

noeliaSD approved these changes Mar 1, 2024

View reviewed changes

feat(@wallet): unknown token

c448239

alaibe force-pushed the feat/unknown-community branch from 26e300f to c448239 Compare March 11, 2024 09:43

alaibe merged commit 115610f into master Mar 11, 2024
8 checks passed

alaibe deleted the feat/unknown-community branch March 11, 2024 10:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(@wallet): unknown token #13737

feat(@wallet): unknown token #13737

alaibe commented Feb 27, 2024 •

edited

status-im-auto commented Feb 27, 2024 •

edited

noeliaSD left a comment

alaibe commented Feb 29, 2024

anastasiyaig commented Feb 29, 2024

caybro left a comment

noeliaSD left a comment

feat(@wallet): unknown token #13737

feat(@wallet): unknown token #13737

Conversation

alaibe commented Feb 27, 2024 • edited

status-im-auto commented Feb 27, 2024 • edited

Jenkins Builds

noeliaSD left a comment

Choose a reason for hiding this comment

alaibe commented Feb 29, 2024

anastasiyaig commented Feb 29, 2024

caybro left a comment

Choose a reason for hiding this comment

noeliaSD left a comment

Choose a reason for hiding this comment

alaibe commented Feb 27, 2024 •

edited

status-im-auto commented Feb 27, 2024 •

edited