Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add api for getting full pending CR object #13749

Merged
merged 1 commit into from
Feb 29, 2024
Merged

feat: Add api for getting full pending CR object #13749

merged 1 commit into from
Feb 29, 2024

Conversation

MishkaRogachev
Copy link
Contributor

Close #13604
Waits status-im/status-go#4819

What does the PR do

Add endpoint for getting latest pending CR for a contact including message

Affected areas

Contacts

Example of data:

{
   "id":"0xb0ee14df8c433398fa017fd404fc535631889b2f73926d3973cafc3416ba0d5d",
   "from":"0x04effb663a86fcc5f7df47b2c945731789e338c7556cb30d935947be4db8be9e3c2791f8f8b19cd46758a887a22af09db522c98508ae0a6d79a2df33cb6468cd15",
   "parsedText":[
      {
         "type":"paragraph",
         "literal":"",
         "destination":"",
         "children":[
            {
               "type":"",
               "literal":"Hi Mishka,,, just testing :)",
               "destination":"",
               "children":[
                  
               ]
            }
         ]
      }
   ],
   "text":"Hi Mishka,,, just testing :)",
   "contactRequestState":2,
   "s

@MishkaRogachev MishkaRogachev linked an issue Feb 27, 2024 that may be closed by this pull request
[Profile flow / backend] No way to get incoming CR message #13604
Closed
@MishkaRogachev MishkaRogachev mentioned this pull request Feb 27, 2024
Merged
1 task
@status-im-auto
Copy link
Member

status-im-auto commented Feb 27, 2024 •
edited

Jenkins Builds

Click to see older builds (17)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 739cde3 #1 2024-02-27 15:54:04 ~28 min windows/x86_64 💿exe
✔️ 739cde3 #1 2024-02-27 15:54:46 ~29 min tests/nim 📄log
✔️ 739cde3 #1 2024-02-27 16:02:03 ~36 min tests/ui 📄log
✔️ 739cde3 #1 2024-02-27 16:02:39 ~37 min linux/x86_64 📦tgz
✔️ 739cde3 #1 2024-02-27 16:38:40 ~1 hr 13 min macos/aarch64 🍎dmg
✔️ 715b3b5 #2 2024-02-27 17:52:33 ~6 min macos/aarch64 🍎dmg
✔️ 715b3b5 #2 2024-02-27 17:53:31 ~7 min tests/nim 📄log
✔️ 715b3b5 #2 2024-02-27 17:59:09 ~12 min tests/ui 📄log
✔️ 715b3b5 #2 2024-02-27 18:06:37 ~20 min linux/x86_64 📦tgz
✔️ 715b3b5 #2 2024-02-27 18:19:10 ~32 min windows/x86_64 💿exe
✔️ 715b3b5 #2 2024-02-27 18:51:23 ~1 hr 5 min macos/x86_64 🍎dmg
✔️ 38db400 #3 2024-02-28 14:33:19 ~4 min macos/aarch64 🍎dmg
✔️ 38db400 #3 2024-02-28 14:35:37 ~7 min tests/nim 📄log
✔️ 38db400 #3 2024-02-28 14:36:19 ~7 min macos/x86_64 🍎dmg
✔️ 38db400 #3 2024-02-28 14:40:18 ~11 min tests/ui 📄log
✔️ 38db400 #3 2024-02-28 14:46:09 ~17 min linux/x86_64 📦tgz
✔️ 38db400 #3 2024-02-28 15:04:03 ~35 min windows/x86_64 💿exe
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 28532fd #4 2024-02-28 15:53:50 ~4 min macos/aarch64 🍎dmg
✔️ 28532fd #4 2024-02-28 15:57:29 ~7 min macos/x86_64 🍎dmg
✔️ 28532fd #4 2024-02-28 15:59:15 ~9 min tests/nim 📄log
✔️ 28532fd #4 2024-02-28 16:04:04 ~14 min tests/ui 📄log
✔️ 28532fd #4 2024-02-28 16:06:18 ~16 min linux/x86_64 📦tgz
✔️ 28532fd #4 2024-02-28 16:19:18 ~29 min windows/x86_64 💿exe
✔️ e7e6b3a #5 2024-02-28 20:07:04 ~4 min macos/aarch64 🍎dmg
✔️ e7e6b3a #5 2024-02-28 20:09:08 ~6 min tests/nim 📄log
✔️ e7e6b3a #5 2024-02-28 20:12:14 ~9 min macos/x86_64 🍎dmg
✔️ e7e6b3a #5 2024-02-28 20:13:44 ~11 min tests/ui 📄log
✔️ e7e6b3a #5 2024-02-28 20:17:31 ~14 min linux/x86_64 📦tgz
❌ e7e6b3a #5 2024-02-28 20:19:19 ~16 min windows/x86_64 📄log
✔️ e7e6b3a #6 2024-02-28 20:49:27 ~19 min windows/x86_64 💿exe

@MishkaRogachev MishkaRogachev force-pushed the 13604-profile-flow-backend-no-way-to-get-incoming-cr-message branch from 739cde3 to 715b3b5 Compare February 27, 2024 17:45
@status-im-auto
Copy link
Member

✔️ status-desktop/prs/linux/x86_64/tests-nim/PR-13749#2 🔹 ~7 min 25 sec 🔹 715b3b5 🔹 📦 tests/nim package

@MishkaRogachev MishkaRogachev force-pushed the 13604-profile-flow-backend-no-way-to-get-incoming-cr-message branch from 715b3b5 to 38db400 Compare February 28, 2024 14:28
caybro
caybro reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls rebase, looks good otherwise!

@MishkaRogachev MishkaRogachev force-pushed the 13604-profile-flow-backend-no-way-to-get-incoming-cr-message branch from 38db400 to 28532fd Compare February 28, 2024 15:49
caybro
caybro approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks 👍

Gonna use it in the UI, will ping back if it doesn't work ;)

@anastasiyaig
Copy link
Contributor

@MishkaRogachev please rebase so tests can pass (do not force push, rebase)

@caybro
Copy link
Member

caybro commented Feb 28, 2024

@MishkaRogachev please rebase so tests can pass (do not force push, rebase)

Well after you rebase, you must force push :)

@anastasiyaig
Copy link
Contributor

sure, correct:)

kounkou
kounkou approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@kounkou kounkou left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need rebase, otherwise 🚢

@MishkaRogachev MishkaRogachev force-pushed the 13604-profile-flow-backend-no-way-to-get-incoming-cr-message branch 2 times, most recently from 28532fd to 422d7dd Compare February 28, 2024 20:12
@MishkaRogachev MishkaRogachev merged commit f934615 into master Feb 29, 2024
8 checks passed
@MishkaRogachev MishkaRogachev deleted the 13604-profile-flow-backend-no-way-to-get-incoming-cr-message branch February 29, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kounkou kounkou kounkou approved these changes

@caybro caybro caybro approved these changes

@igor-sirotin igor-sirotin Awaiting requested review from igor-sirotin

Assignees
No one assigned
Labels
waiting-for-status-go-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Profile flow / backend] No way to get incoming CR message
5 participants
@MishkaRogachev @status-im-auto @anastasiyaig @caybro @kounkou