fix: show pending ban/unban/kick state if the control node is offline #13752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (9)
|
jrainville
reviewed
Feb 27, 2024
src/app/modules/main/module.nim
Outdated
| isContact = contactDetails.dto.isContact, | ||
| isVerified = contactDetails.dto.isContactVerified(), | ||
| membershipRequestState = state, | ||
| ) |
There was a problem hiding this comment.
Small suggestion, maybe we can create util function in this module where we pass the contactDetails and memberId and it does the initMemberItem. That way we don't have to duplicate all those lines.
jrainville
approved these changes
Feb 27, 2024
mprakhov
force-pushed
the
mp/issue-13596
branch
2 times, most recently
from
ff0ebc9
to
19a56e3
Compare
jrainville
reviewed
Feb 27, 2024
| @@ -1649,4 +1596,23 @@ method checkIfAddressWasCopied*[T](self: Module[T], value: string) = | |||
| return | |||
| self.addressWasShown(value) | |||
|
|
|||
| method createMemberItem*[T](self: Module[T], memberId: string, state: MembershipRequestState, role: MemberRole): MemberItem = | |||
There was a problem hiding this comment.
Did you forget to create the forward declaration?
There was a problem hiding this comment.
hm... but it is working
There was a problem hiding this comment.
Maybe it's because of the io_interface?
There was a problem hiding this comment.
maybe... I don't have deep knowledge of NIM, but during dev testing, everything is ok + this should be a compilation error
MishkaRogachev
approved these changes
Feb 28, 2024
src/app/modules/main/module.nim
Outdated
| icon = contactDetails.icon, | ||
| colorId = contactDetails.colorId, | ||
| colorHash = contactDetails.colorHash, | ||
| onlineStatus = toOnlineStatus(self.controller.getStatusForContactWithId(memberId).statusType), |
There was a problem hiding this comment.
suggestion:
let status = self.controller.getStatusForContactWithId(memberId)
...
onlineStatus = toOnlineStatus(status.statusType)
19a56e3
to
b46d738
Compare
mprakhov
force-pushed
the
mp/issue-13596
branch
from
b46d738
to
88d8530
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Show pending ban/unban/kick state if the control node is offline
Closes: #13596
Affected areas
kick/ban/unban state in the member's list