Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update status-go: fix change password crash #13753

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

igor-sirotin
Copy link
Contributor

@igor-sirotin igor-sirotin commented Feb 27, 2024

@status-im-auto
Copy link
Member

status-im-auto commented Feb 27, 2024

Jenkins Builds

Click to see older builds (5)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ db4f349 #1 2024-02-27 16:35:12 ~8 min tests/nim 📄log
✔️ db4f349 #1 2024-02-27 16:41:48 ~14 min tests/ui 📄log
✔️ db4f349 #1 2024-02-27 16:46:06 ~19 min linux/x86_64 📦tgz
✔️ db4f349 #1 2024-02-27 16:52:01 ~25 min windows/x86_64 💿exe
✔️ db4f349 #1 2024-02-27 17:03:24 ~36 min macos/aarch64 🍎dmg
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ baa92fe #2 2024-02-27 17:23:47 ~6 min tests/nim 📄log
✔️ baa92fe #2 2024-02-27 17:24:58 ~7 min macos/aarch64 🍎dmg
✔️ baa92fe #2 2024-02-27 17:31:51 ~14 min linux/x86_64 📦tgz
✔️ baa92fe #2 2024-02-27 17:33:54 ~16 min tests/ui 📄log
✔️ baa92fe #2 2024-02-27 17:35:15 ~18 min windows/x86_64 💿exe
✔️ baa92fe #2 2024-02-27 18:31:41 ~1 hr 14 min macos/x86_64 🍎dmg
✔️ 606486c #4 2024-02-27 19:12:20 ~5 min tests/nim 📄log
✔️ 606486c #4 2024-02-27 19:12:42 ~6 min macos/aarch64 🍎dmg
✔️ 606486c #4 2024-02-27 19:17:05 ~10 min tests/ui 📄log
✔️ 606486c #4 2024-02-27 19:17:14 ~10 min macos/x86_64 🍎dmg
✔️ 606486c #4 2024-02-27 19:23:01 ~16 min linux/x86_64 📦tgz
✔️ 606486c #4 2024-02-27 19:44:12 ~37 min windows/x86_64 💿exe

@anastasiyaig anastasiyaig self-requested a review February 27, 2024 17:03
@anastasiyaig
Copy link
Contributor

the test of changing password is failing https://ci.status.im/job/status-desktop/job/e2e/job/manual/1513/
the test of syncing is failing as well

ERROR[02-27|16:54:22.129|github.com/status-im/status-go/api/geth_backend.go:432] failed to initialize wallet db           package=status-go/api.GethStatusBackend err="failed to set `journal_mode` pragma: file is not a database"
failed to set `journal_mode` pragma: file is not a database
�[91mERR�[0m 2024-02-27 16:54:22.129+00:00 �[1merror:                                    �[0m topics="�[93maccounts-service�[0m" �[91mtid�[0m=�[94m3876913�[0m �[91mfile�[0m=�[94mservice.nim:673�[0m �[91mprocName�[0m=�[94mverifyDatabasePassword�[0m �[91merrDesription�[0m=�[94m"failed to set `journal_mode` pragma: file is not a database"�[0m
�[90mDBG�[0m 2024-02-27 16:54:22.130+00:00 �[1mAccount logged in                         �[0m topics="�[93maccounts-service�[0m" �[90mtid�[0m=�[94m3876913�[0m �[90mfile�[0m=�[94mservice.nim:693�[0m
WARN [02-27|16:54:22.130|github.com/status-im/status-go/common/dbsetup/db_setup.go:26] GetDBFilename was passed a nil pointer sql.DB 
Warning: The X11 connection broke: I/O error (code 1) (:0, )
XIO:  fatal IO error 17 (File exists) on X server ":1"
      after 542 requests (540 known processed) with 0 events remaining.
Warning: QObject::~QObject: Timers cannot be stopped from another thread (:0, )

Copy link
Contributor

@anastasiyaig anastasiyaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tested it and the mentioned issue above is now fixed

@kounkou
Copy link
Contributor

kounkou commented Feb 27, 2024

This PR has conflicts still

Copy link
Contributor

@kounkou kounkou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@igor-sirotin igor-sirotin merged commit a6513e4 into master Feb 27, 2024
8 checks passed
@igor-sirotin igor-sirotin deleted the fix/issue-13748 branch February 27, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings -> Change password: change password is broken
5 participants