Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix/biometrics) Fix biometric authentication #13793

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

kounkou
Copy link
Contributor

@kounkou kounkou commented Feb 29, 2024

Description

fixes #13051 User blocked in model when using biometrics to share address when joining a community.

What does the PR do

There was a missing connection of the connect signal coming from the Key chain after entering a password and correctly obtaining data from the Keychain service. So this PR just connects the signal to the already existing signal processor

Affected areas

NA

Screenshot of functionality (including design for comparison)

output

@kounkou kounkou self-assigned this Feb 29, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Feb 29, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9eead0a #1 2024-02-29 21:00:33 ~6 min tests/nim 📄log
✔️ 9eead0a #1 2024-02-29 21:02:14 ~8 min macos/aarch64 🍎dmg
✔️ 9eead0a #1 2024-02-29 21:04:20 ~10 min macos/x86_64 🍎dmg
✔️ 9eead0a #1 2024-02-29 21:04:53 ~10 min tests/ui 📄log
✔️ 9eead0a #1 2024-02-29 21:10:55 ~16 min linux/x86_64 📦tgz
✔️ 9eead0a #1 2024-02-29 21:24:25 ~30 min windows/x86_64 💿exe
✔️ 1489220 #2 2024-03-01 04:59:49 ~4 min macos/aarch64 🍎dmg
✔️ 1489220 #2 2024-03-01 05:00:57 ~6 min tests/nim 📄log
✔️ 1489220 #2 2024-03-01 05:02:05 ~7 min macos/x86_64 🍎dmg
✔️ 1489220 #2 2024-03-01 05:05:05 ~10 min tests/ui 📄log
✔️ 1489220 #2 2024-03-01 05:09:57 ~15 min linux/x86_64 📦tgz
✔️ 1489220 #2 2024-03-01 05:17:42 ~22 min windows/x86_64 💿exe

fixes #13051 User blocked in model when using biometrics to share
address when joining a community
@kounkou kounkou force-pushed the fix-biometric-authentication branch from 9eead0a to 1489220 Compare March 1, 2024 04:54
@kounkou kounkou merged commit 0fab8e3 into master Mar 1, 2024
8 checks passed
@kounkou kounkou deleted the fix-biometric-authentication branch March 1, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User is blocked in modal when using biometrics to share addresses when joining a community
4 participants