feat(Profile flow): Respond to/review an incoming CR #13794
Conversation
caybro
requested review from
MishkaRogachev,
alexandraB99,
alexjba and
noeliaSD
| } | ||
| onDiscarded: { | ||
| // FIXME should call `rootStore.contactStore.dismissContactRequest(publicKey, contactRequestId)` here? | ||
| Global.displaySuccessToastMessage(qsTr("Contact request ignored")) |
There was a problem hiding this comment.
One question here @MishkaRogachev: here we should just "ignore" the request but all the other popups (ActivityCenter, Settings/Contacts, etc) still call the dismissContactRequest; so what to do here?
There was a problem hiding this comment.
not sure if i get the problem. Maybe add an arg to openPopup(reviewContactRequestPopupComponent, ... in case ActivityCenter, Settings/Contacts and Profile uses the same component
There was a problem hiding this comment.
No, my main question is more about the behavior, whether we should just ignore the CR everywhere, instead of calling the "dismiss" function (depending on what it does internally)
There was a problem hiding this comment.
i'm not aware of latest requirements, but i can answer what dismissContactRequest does:
- mark provided or latest CR as Dismissed
- set contact's
ContactRequestLocalStateas ContactRequestStateDismissed. All subsequent CRs from this contact will not change the contact's status and trigger AC notifications
So my opinion is to use dismissContactRequest to ignore a contact
Jenkins Builds
|
- implement the new "Reviewing contact request" popup & flow - adjust storybook Fixes #13519
caybro
force-pushed
the
13519-feat-review-incoming-cr
branch
from
796f00b
to
2f09802
Compare
What does the PR do
Fixes #13519
Affected areas
ProfileDialogView,ProfileContextMenu
Screenshot of functionality (including design for comparison)