Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ProfileShowcase) Web tab visual updates according to new design #13818

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

noeliaSD
Copy link
Contributor

@noeliaSD noeliaSD commented Mar 3, 2024

Closes #13511

What does the PR do

  • Updated AddSocialLinkModal according to new design.
  • Modified main social links items according to new design.
  • Updated edit modal according to new design.
  • Some text validation updates.

Affected areas

Profile Showcase / Web tab

Screenshot of functionality

Screen.Recording.2024-03-03.at.16.26.58.mov

- Updated `AddSocialLinkModal` according to new design.
- Modified main social links items according to new design.
- Updated edit modal according to new design.
- Some text validation updates.

Closes #13511
@noeliaSD noeliaSD self-assigned this Mar 3, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Mar 3, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c9e0e6f #1 2024-03-03 15:37:36 ~6 min tests/nim 📄log
✔️ c9e0e6f #1 2024-03-03 15:39:51 ~8 min macos/aarch64 🍎dmg
✔️ c9e0e6f #1 2024-03-03 15:40:44 ~9 min macos/x86_64 🍎dmg
✔️ c9e0e6f #1 2024-03-03 15:42:14 ~10 min tests/ui 📄log
✔️ c9e0e6f #1 2024-03-03 15:47:57 ~16 min linux/x86_64 📦tgz
✔️ c9e0e6f #1 2024-03-03 16:05:24 ~34 min windows/x86_64 💿exe

Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noeliaSD noeliaSD merged commit babedf4 into master Mar 4, 2024
8 checks passed
@noeliaSD noeliaSD deleted the feat/issue-13511 branch March 4, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Profile Showcase] Compare existing implementation of Web tab with the new design and update the differences
4 participants