-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ProfileShowcase): Add search input in all tabs #13819
Conversation
Jenkins BuildsClick to see older builds (44)
|
2e2d1d0
to
54b8dfd
Compare
54b8dfd
to
af20d2c
Compare
687cafd
to
9bfec68
Compare
1f2d1eb
to
547c4a2
Compare
9bfec68
to
39682d0
Compare
547c4a2
to
446a7e9
Compare
29ebd50
to
f0eee4b
Compare
446a7e9
to
9d7fda7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 👍
9d7fda7
to
1575959
Compare
Rebased! |
- Added searcher input in header. - Added 2 filter proxies for hidden and inshowcase models depending on search text. - Added filter expression per showcase tab (accounts, collectibles and communities). - Added specific placeholder when search empty. - Added specific logic when search active. - Added search validation. Closes #13508
1575959
to
88c3040
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Closes #13508
What does the PR do
Affected areas
Profile Showcase / Community, Assets, Accounts and Collectibles tabs
Screenshot of functionality
Screen.Recording.2024-03-06.at.11.43.16.mov