Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ProfileShowcase): Add search input in all tabs #13819

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

noeliaSD
Copy link
Contributor

@noeliaSD noeliaSD commented Mar 3, 2024

Closes #13508

What does the PR do

  • Added searcher input in header.
  • Added 2 filter proxies for hidden and inshowcase models depending on search text.
  • Added filter expression per showcase tab (accounts, collectibles and communities).
  • Added specific placeholder when search empty.
  • Added specific logic when search active.
  • Added search validation.

Affected areas

Profile Showcase / Community, Assets, Accounts and Collectibles tabs

Screenshot of functionality

Screen.Recording.2024-03-06.at.11.43.16.mov

@noeliaSD noeliaSD self-assigned this Mar 3, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Mar 3, 2024

Jenkins Builds

Click to see older builds (44)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2e2d1d0 #1 2024-03-03 16:44:54 ~5 min tests/nim 📄log
✔️ 2e2d1d0 #1 2024-03-03 16:47:41 ~8 min macos/aarch64 🍎dmg
✔️ 2e2d1d0 #1 2024-03-03 16:49:27 ~10 min tests/ui 📄log
✔️ 2e2d1d0 #1 2024-03-03 16:51:08 ~12 min macos/x86_64 🍎dmg
✔️ 2e2d1d0 #1 2024-03-03 16:55:28 ~16 min linux/x86_64 📦tgz
✔️ 2e2d1d0 #1 2024-03-03 17:07:21 ~28 min windows/x86_64 💿exe
✔️ 54b8dfd #3 2024-03-05 12:56:24 ~6 min macos/aarch64 🍎dmg
✔️ 54b8dfd #3 2024-03-05 12:56:30 ~6 min tests/nim 📄log
✔️ 54b8dfd #3 2024-03-05 13:00:34 ~10 min tests/ui 📄log
✔️ 54b8dfd #3 2024-03-05 13:01:35 ~11 min macos/x86_64 🍎dmg
✔️ 54b8dfd #3 2024-03-05 13:07:05 ~17 min linux/x86_64 📦tgz
✔️ 54b8dfd #3 2024-03-05 13:17:56 ~28 min windows/x86_64 💿exe
✔️ af20d2c #4 2024-03-05 16:58:50 ~4 min macos/aarch64 🍎dmg
✔️ af20d2c #4 2024-03-05 17:00:28 ~6 min tests/nim 📄log
✔️ af20d2c #4 2024-03-05 17:02:08 ~8 min macos/x86_64 🍎dmg
✔️ af20d2c #4 2024-03-05 17:04:49 ~10 min tests/ui 📄log
✔️ af20d2c #4 2024-03-05 17:09:23 ~15 min linux/x86_64 📦tgz
✔️ af20d2c #4 2024-03-05 17:22:42 ~28 min windows/x86_64 💿exe
✔️ 1f2d1eb #5 2024-03-06 09:03:31 ~4 min macos/aarch64 🍎dmg
✔️ 1f2d1eb #5 2024-03-06 09:05:51 ~6 min tests/nim 📄log
✔️ 1f2d1eb #5 2024-03-06 09:06:54 ~7 min macos/x86_64 🍎dmg
✔️ 1f2d1eb #5 2024-03-06 09:10:43 ~11 min tests/ui 📄log
✔️ 1f2d1eb #5 2024-03-06 09:16:00 ~16 min linux/x86_64 📦tgz
✔️ 1f2d1eb #5 2024-03-06 09:28:00 ~28 min windows/x86_64 💿exe
✔️ 547c4a2 #6 2024-03-06 10:42:05 ~5 min macos/aarch64 🍎dmg
✔️ 547c4a2 #6 2024-03-06 10:42:26 ~6 min tests/nim 📄log
✔️ 547c4a2 #6 2024-03-06 10:43:32 ~7 min macos/x86_64 🍎dmg
✔️ 446a7e9 #7 2024-03-06 10:49:41 ~4 min macos/aarch64 🍎dmg
✔️ 446a7e9 #7 2024-03-06 10:51:45 ~6 min tests/nim 📄log
✔️ 446a7e9 #7 2024-03-06 10:52:38 ~6 min macos/x86_64 🍎dmg
✔️ 446a7e9 #7 2024-03-06 10:56:12 ~10 min tests/ui 📄log
✔️ 446a7e9 #7 2024-03-06 11:01:29 ~15 min linux/x86_64 📦tgz
✔️ 446a7e9 #7 2024-03-06 11:10:05 ~24 min windows/x86_64 💿exe
✔️ 9d7fda7 #8 2024-03-06 15:06:44 ~5 min macos/aarch64 🍎dmg
✔️ 9d7fda7 #8 2024-03-06 15:07:24 ~6 min tests/nim 📄log
✔️ 9d7fda7 #8 2024-03-06 15:08:31 ~7 min macos/x86_64 🍎dmg
✔️ 9d7fda7 #8 2024-03-06 15:11:47 ~10 min tests/ui 📄log
✔️ 9d7fda7 #8 2024-03-06 15:16:28 ~15 min linux/x86_64 📦tgz
✔️ 9d7fda7 #8 2024-03-06 15:28:54 ~27 min windows/x86_64 💿exe
✔️ 9d7fda7 #9 2024-03-07 15:15:27 ~4 min macos/aarch64 🍎dmg
✔️ 9d7fda7 #9 2024-03-07 15:17:24 ~6 min tests/nim 📄log
✔️ 9d7fda7 #9 2024-03-07 15:18:45 ~7 min macos/x86_64 🍎dmg
✔️ 9d7fda7 #9 2024-03-07 15:22:17 ~11 min tests/ui 📄log
✔️ 9d7fda7 #9 2024-03-07 15:26:04 ~15 min linux/x86_64 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1575959 #10 2024-03-07 15:36:32 ~3 min macos/aarch64 🍎dmg
✔️ 1575959 #10 2024-03-07 15:38:35 ~5 min tests/nim 📄log
✔️ 1575959 #10 2024-03-07 15:39:29 ~6 min macos/x86_64 🍎dmg
✔️ 1575959 #10 2024-03-07 15:43:15 ~10 min tests/ui 📄log
✔️ 1575959 #10 2024-03-07 15:46:52 ~14 min linux/x86_64 📦tgz
✔️ 1575959 #10 2024-03-07 16:05:04 ~32 min windows/x86_64 💿exe
✔️ 88c3040 #11 2024-03-08 09:13:47 ~4 min macos/aarch64 🍎dmg
✔️ 88c3040 #11 2024-03-08 09:15:46 ~6 min tests/nim 📄log
✔️ 88c3040 #11 2024-03-08 09:17:20 ~7 min macos/x86_64 🍎dmg
✔️ 88c3040 #11 2024-03-08 09:19:55 ~10 min tests/ui 📄log
✔️ 88c3040 #11 2024-03-08 09:24:27 ~14 min linux/x86_64 📦tgz
✔️ 88c3040 #11 2024-03-08 09:35:30 ~25 min windows/x86_64 💿exe

@noeliaSD noeliaSD changed the base branch from master to feat/issue-13507 March 5, 2024 12:49
@noeliaSD noeliaSD force-pushed the feat/issue-13508 branch 2 times, most recently from 1f2d1eb to 547c4a2 Compare March 6, 2024 10:35
@noeliaSD noeliaSD marked this pull request as ready for review March 6, 2024 10:47
@noeliaSD noeliaSD force-pushed the feat/issue-13507 branch 3 times, most recently from 29ebd50 to f0eee4b Compare March 6, 2024 14:35
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍

Base automatically changed from feat/issue-13507 to master March 7, 2024 15:10
@noeliaSD
Copy link
Contributor Author

noeliaSD commented Mar 7, 2024

Rebased!

- Added searcher input in header.
- Added 2 filter proxies for hidden and inshowcase models depending on search text.
- Added filter expression per showcase tab (accounts, collectibles and communities).
- Added specific placeholder when search empty.
- Added specific logic when search active.
- Added search validation.

Closes #13508
Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@noeliaSD noeliaSD merged commit a9b5d8f into master Mar 8, 2024
8 checks passed
@noeliaSD noeliaSD deleted the feat/issue-13508 branch March 8, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Profile Showcase] Add search input in all tabs
4 participants