fix(chat input): should be disabled if user is not able to post #13825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (18)
|
caybro
changed the title
caybro
commented
Mar 4, 2024
| @@ -1246,7 +1246,7 @@ Rectangle { | |||
| padding: 0 | |||
| // This is needed to make sure the text area is disabled when the input is disabled | |||
| Binding on enabled { | |||
| value: root.enabled | |||
| value: control.enabled | |||
There was a problem hiding this comment.
The top element is called control here, not root
jrainville
approved these changes
Mar 4, 2024
jrainville
requested changes
Mar 4, 2024
There was a problem hiding this comment.
I tested this branch because I needed to also modify something relative to the blocked chat input and while testing I found a bug. As soon as a channel has a permission, you can no longer post on it. In this case, I am a TM and the field says that all is good, but I can click on the input an write
input.webm
jrainville
reviewed
Mar 4, 2024
|
FYI, I opened a PR that adds a new disabled message for when a permission is pending. A dumb way to fix the issue for now would be to disable the input when the placeholder text is not |
caybro
force-pushed
the
13777-chat-input-should-be-disabled-if-user-is-not-able-to-post
branch
from
484bd7a
to
a91f577
Compare
caybro
force-pushed
the
13777-chat-input-should-be-disabled-if-user-is-not-able-to-post
branch
2 times, most recently
from
c2e7fb4
to
1006085
Compare
- extend `isUserAllowedToSendMessage` to also cover `Constants.chatType.communityChat` - let `admin` always satisfy the permissions - hide the add emoji/reaction button instead of disabling it when the permissions are not met - adjust the error msg to better reflect the reality (tokens vs. permissions) Fixes #13777
caybro
force-pushed
the
13777-chat-input-should-be-disabled-if-user-is-not-able-to-post
branch
from
1006085
to
ff3b36f
Compare
jrainville
reviewed
Mar 5, 2024
caybro
deleted the
13777-chat-input-should-be-disabled-if-user-is-not-able-to-post
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
isUserAllowedToSendMessageto also coverConstants.chatType.communityChatadminalways satisfy the permissionsFixes #13777
Affected areas
StatusChatInput,ChatColumnView
Screenshot of functionality (including design for comparison)
Zaznam.obrazovky.z.2024-03-04.11-17-37.webm