feat(SettingsContentBase): Save changes bubble overlapping by default #13827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
|
@noeliaSD please rebase when you are ready to submit the PR , so tests could pass |
caybro
reviewed
Mar 4, 2024
noeliaSD
force-pushed
the
feat/issue-13517
branch
from
51087dd
to
f266a94
Compare
- Added `autoscrollWhenDirty` property to be able to configure the settings content base as autoscroll mode when dirty toast appears. Otherwise, the toast will be shown overlaid on top of the view content. - Updated profile view to setup autoscroll on `Identity` tab. Rest of app cases are setup with the overlay mode. Closes #13517
Manual calculation of bubble postion to be correctly centered due to the usage of `SettingsContentBase` as a centralPanel component that already has a default left margin value.
noeliaSD
force-pushed
the
feat/issue-13517
branch
from
f266a94
to
da4cdf4
Compare
noeliaSD
changed the title
alexandraB99
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13517
What does the PR do
autoscrollWhenDirtyproperty to be able to configure the settings content base as autoscroll mode when dirty toast appears. Otherwise, the toast will be shown overlaid on top of the view content.Identitytab. Rest of app cases are setup with the overlay mode.Affected areas
Setting pages
Screenshot of functionality
Screen.Recording.2024-03-04.at.13.43.12.mov