Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(StatusQ): Don't emit layoutChanged on source model reset in MovableModel #13873

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

alexjba
Copy link
Contributor

@alexjba alexjba commented Mar 7, 2024

What does the PR do

Don't emit layoutChanged when the source model changes.

+Update tests

Affected areas

MovableModel

@status-im-auto
Copy link
Member

status-im-auto commented Mar 7, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7fba8eb #1 2024-03-07 08:03:23 ~5 min tests/nim 📄log
✔️ 7fba8eb #1 2024-03-07 08:06:08 ~8 min macos/aarch64 🍎dmg
✔️ 7fba8eb #1 2024-03-07 08:08:01 ~10 min tests/ui 📄log
✔️ 7fba8eb #1 2024-03-07 08:10:03 ~12 min macos/x86_64 🍎dmg
✔️ 7fba8eb #1 2024-03-07 08:13:33 ~15 min linux/x86_64 📦tgz
✔️ 7fba8eb #1 2024-03-07 08:31:45 ~34 min windows/x86_64 💿exe

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

Copy link
Member

@micieslak micieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alexjba alexjba merged commit 07ac4eb into master Mar 7, 2024
8 checks passed
@alexjba alexjba deleted the fix/movable_model branch March 7, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants