13291 hide channels #13876
Merged
13291 hide channels #13876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
jrainville
reviewed
Mar 7, 2024
| @@ -227,6 +263,18 @@ QtObject: | |||
| defer: index.delete | |||
| self.dataChanged(index, index, @[ModelRole.CategoryOpened.int]) | |||
|
|
|||
| proc changeCategoryItemIfHiddenBecauseNoPermitted*(self: Model, id: string) = | |||
There was a problem hiding this comment.
I guess you made a typo?
Suggested change
| proc changeCategoryItemIfHiddenBecauseNoPermitted*(self: Model, id: string) = | |
| proc changeCategoryItemIsHiddenBecauseNotPermitted*(self: Model, id: string) = |
igor-sirotin
approved these changes
Mar 12, 2024
endulab
force-pushed
the
13291-hide-channels
branch
2 times, most recently
from
eca5b7b
to
eca9b29
Compare
…d to view and hideIfPermissionsNotMet is set Extend chats model with channel permissions info and hideIfPermissionsNotMet. Visibility of chat item is based on: member roles, channel permissions, hideIfPermissionsNotMet. If all channels from category are hidden, category item is also hidden. If all chats in community are hidden, infomration label is displayed. Issue #13291
endulab
force-pushed
the
13291-hide-channels
branch
from
eca9b29
to
0556f69
Compare
Khushboo-dev-cpp
pushed a commit
that referenced
this pull request
Mar 19, 2024
* feat(@desktop/communities): Hide channels if the user is not permitted to view and hideIfPermissionsNotMet is set Extend chats model with channel permissions info and hideIfPermissionsNotMet. Visibility of chat item is based on: member roles, channel permissions, hideIfPermissionsNotMet. If all channels from category are hidden, category item is also hidden. If all chats in community are hidden, infomration label is displayed. Issue #13291 * chore(@desktop): Upgrade status-go Issue #13291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Extend chats model with channel permissions info and hideIfPermissionsNotMet.
Visibility of chat item is based on: member roles, channel permissions, hideIfPermissionsNotMet.
If all channels from category are hidden, category item is also hidden.
If all channels in community are hidden, information label is displayed.
Related status-go pr
Issue #13291
hide-channels.mov