fix[CI] PagesValidator UI test doesn't catch missing required properties
#13907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rties - use the full `QQmlEngine` to test loading of the component Fixes #13901
Jenkins BuildsClick to see older builds (6)
|
caught by the fixed PagesValidator test
noeliaSD
reviewed
Mar 8, 2024
- reuse the existing `Constants.settingsSection.leftMargin` without the required property
caybro
force-pushed
the
13901-ci-pages_validator-ui-test-doesnt-catch-missing-required-properties
branch
from
fe822a9
to
8e05f07
Compare
caybro
deleted the
13901-ci-pages_validator-ui-test-doesnt-catch-missing-required-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
QQmlEngineto test loading of the componentFixes #13901
Affected areas
CI/StoryBook
Screenshot of functionality (including design for comparison)
Before:
After:
