feat(@desktop/wallet): Main Collectible Detail View enhancements #13919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khushboo-dev-cpp
force-pushed
the
feat/issue-13804
branch
from
d91eeab
to
b89dbd2
Compare
Jenkins BuildsClick to see older builds (6)
|
Khushboo-dev-cpp
force-pushed
the
feat/issue-13804
branch
from
b89dbd2
to
14cd83e
Compare
Khushboo-dev-cpp
force-pushed
the
feat/issue-13804
branch
from
14cd83e
to
019c05f
Compare
Khushboo-dev-cpp
requested review from
saledjenic,
alaibe,
dlipicar,
Cuteivist,
IvanBelyakoff and
stefandunca
Cuteivist
approved these changes
Mar 12, 2024
caybro
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Those icons do not look "tiny" :) Should be 16x16 at best, these are 24x24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13804
What does the PR do
Implements the design changes in the Collectibles Details view
Please not the popup out to open sea and logo in the collection tag will be updated under the task below-
#13918
#13927
Affected areas
CollectibleDetailsView
StatusQ checklist
Screenshot of functionality (including design for comparison)
Screen.Recording.2024-03-12.at.12.52.51.PM.mov