-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent forever chat loading animation #13929
Conversation
Jenkins Builds
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>>> Error loading StoryBook page: QUrl("file:///home/jenkins/workspace/s_linux_x86_64_tests-ui_PR-13929/storybook/pages/EditPermissionViewPage.qml")
Looks like a legit UI-test failure but maybe you just have to rebase 🤔
Also the commit mess needs some squashing :)
Otherwise LGTM
@caybro Don't worry, I'm keeping an eye on the tests result.
Sure. I usually use |
@caybro FYI actually that was some kind of a glitch on CI. https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-13929/ The page runs ok for me locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Fixes #13533
Description
Prevent forever scrolling if loading new messages didn't start.
(e.g. because all cursor is
mostRecent
orpending
)status-desktop/src/app/modules/main/chat_section/chat_content/messages/module.nim
Lines 366 to 369 in 5423bdf
Prevent scrolling to messages that exist, but will never be loaded to the model, because they're not displayable.
status-desktop/src/app/modules/main/chat_section/chat_content/messages/module.nim
Lines 668 to 672 in 5423bdf
Fixed behaviour when clicking on a AC contact request and verification request notifications.
Instead of trying to scroll to message we now profile popup.
Removed
CURSOR_VALUE_IGNORE
. It's just simpler.Added "Copy chat ID" action to chat context menu.
Also moved all debug actions to a submenu.
Screenshot
Screen.Recording.2024-03-11.at.22.17.01.mov